-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image urls with no extension and no content-type header fails #23
Comments
@nickvelloff The URL is incomplete, can you paste again? |
@nickvelloff cannot reproduce that exact error. However I do get a black image output. Looking at the response data from the input URL, it does not set any Content-Header. This combined with no extension means that we don't know which file type is in use. |
So this is a URL that has been consumed by the /share endpoint. Thus any lack of specific image information required is in the flow of the URL data consumption on the API side. Would this be considered a bug I should surface?
|
Browsers handle this case, so should imgflo. Its just a bit tricky with the But probably could write a little image type sniffer and run that on the
|
Cool well let me know if you would like me to reproduce the specific payload for testing.
|
Source image url from Evernote (Media block with cover)
https://www.evernote.com/shard/s31/sh/697b5242-7e79-4565-b1bb-74d9987ed3cb/c591bfd1c137afa6a681bb975f15a5f2/thm/note/697b5242-7e79-4565-b1bb-74d9987ed3cb
Produced url:
https://imgflo.herokuapp.com/graph/...../passthrough?height=720&input=https%3A%2F%2Fwww.evernote.com%2Fshard%2Fs31%2Fsh%2F697b5242-7e79-4565-b1bb-74d9987ed3cb%2Fc591bfd1c137afa6a681bb975f15a5f2%2Fthm%2Fnote%2F697b5242-7e79-4565-b1bb-74d9987ed3cb
Error:
{"errno":-2,"code":"ENOENT","path":"temp/01e69e264a7829dbb17e6bfd0a887b51960f6ad9.jpg"}
The text was updated successfully, but these errors were encountered: