Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory leak due to go routines #346

Merged
merged 4 commits into from
May 4, 2021
Merged

Fix memory leak due to go routines #346

merged 4 commits into from
May 4, 2021

Conversation

jonny-rimek
Copy link
Owner

fix #334

@github-actions
Copy link

github-actions bot commented May 3, 2021 

Stack wm
Resources
[~] AWS::Lambda::Function Api-/Lambda ApiLambdaB75D04FB 
 ├─ [~] Code
 │   └─ [~] .S3Key:
 │       ├─ [-] c070daac02489a748e9e0644a4457029e3a83e5040022b98ebd633daa7185557.zip
 │       └─ [+] 2a2dd2b026f1d171665207eb38bc3f350f5dd3ffa7de786ad8e4158b50154c8e.zip
 └─ [~] Metadata
     └─ [~] .aws:asset:path:
         ├─ [-] asset.c070daac02489a748e9e0644a4457029e3a83e5040022b98ebd633daa7185557
         └─ [+] asset.2a2dd2b026f1d171665207eb38bc3f350f5dd3ffa7de786ad8e4158b50154c8e
[~] Custom::CDKBucketDeployment Frontend-/DeployWebsite/CustomResource FrontendDeployWebsiteCustomResource1B4A6C7F 
 └─ [~] SourceObjectKeys
     └─ @@ -1,3 +1,3 @@
        [ ] [
        [-]   "8e2f46491c624e46a366b39f73b33d84b38bcf713f064d1ae042cde9d21a6278.zip"
        [+]   "9cccad051d1fae79347fff72b27206af81e9401057d07082c29f23f864a99715.zip"
        [ ] ]
[~] AWS::SQS::Queue Convert-/ProcessingQueue ConvertProcessingQueueE8D6E023 
 └─ [~] VisibilityTimeout
     ├─ [-] 1800
     └─ [+] 900
[~] AWS::Lambda::Function Convert-/Lambda ConvertLambda3540DCCB 
 └─ [~] Timeout
     ├─ [-] 300
     └─ [+] 150

@jonny-rimek jonny-rimek changed the title Fix memory lead due to go routines Fix memory leak due to go routines May 3, 2021
@github-actions
Copy link

github-actions bot commented May 3, 2021 

Stack wm
Resources
[~] AWS::Lambda::Function Api-/Lambda ApiLambdaB75D04FB 
 ├─ [~] Code
 │   └─ [~] .S3Key:
 │       ├─ [-] c070daac02489a748e9e0644a4457029e3a83e5040022b98ebd633daa7185557.zip
 │       └─ [+] 2a2dd2b026f1d171665207eb38bc3f350f5dd3ffa7de786ad8e4158b50154c8e.zip
 └─ [~] Metadata
     └─ [~] .aws:asset:path:
         ├─ [-] asset.c070daac02489a748e9e0644a4457029e3a83e5040022b98ebd633daa7185557
         └─ [+] asset.2a2dd2b026f1d171665207eb38bc3f350f5dd3ffa7de786ad8e4158b50154c8e
[~] Custom::CDKBucketDeployment Frontend-/DeployWebsite/CustomResource FrontendDeployWebsiteCustomResource1B4A6C7F 
 └─ [~] SourceObjectKeys
     └─ @@ -1,3 +1,3 @@
        [ ] [
        [-]   "8e2f46491c624e46a366b39f73b33d84b38bcf713f064d1ae042cde9d21a6278.zip"
        [+]   "9cccad051d1fae79347fff72b27206af81e9401057d07082c29f23f864a99715.zip"
        [ ] ]
[~] AWS::SQS::Queue Convert-/ProcessingQueue ConvertProcessingQueueE8D6E023 
 └─ [~] VisibilityTimeout
     ├─ [-] 1800
     └─ [+] 900
[~] AWS::Lambda::Function Convert-/Lambda ConvertLambda3540DCCB 
 ├─ [~] MemorySize
 │   ├─ [-] 3584
 │   └─ [+] 2500
 └─ [~] Timeout
     ├─ [-] 300
     └─ [+] 150

@github-actions
Copy link

github-actions bot commented May 4, 2021 

Stack wm
Resources
[~] AWS::Lambda::Function Api-/Lambda ApiLambdaB75D04FB 
 ├─ [~] Code
 │   └─ [~] .S3Key:
 │       ├─ [-] c070daac02489a748e9e0644a4457029e3a83e5040022b98ebd633daa7185557.zip
 │       └─ [+] 2a2dd2b026f1d171665207eb38bc3f350f5dd3ffa7de786ad8e4158b50154c8e.zip
 └─ [~] Metadata
     └─ [~] .aws:asset:path:
         ├─ [-] asset.c070daac02489a748e9e0644a4457029e3a83e5040022b98ebd633daa7185557
         └─ [+] asset.2a2dd2b026f1d171665207eb38bc3f350f5dd3ffa7de786ad8e4158b50154c8e
[~] Custom::CDKBucketDeployment Frontend-/DeployWebsite/CustomResource FrontendDeployWebsiteCustomResource1B4A6C7F 
 └─ [~] SourceObjectKeys
     └─ @@ -1,3 +1,3 @@
        [ ] [
        [-]   "8e2f46491c624e46a366b39f73b33d84b38bcf713f064d1ae042cde9d21a6278.zip"
        [+]   "9cccad051d1fae79347fff72b27206af81e9401057d07082c29f23f864a99715.zip"
        [ ] ]
[~] AWS::Lambda::Function InsertKeysToTimestream-/Lambda InsertKeysToTimestreamLambdaA07E952E 
 ├─ [~] Code
 │   └─ [~] .S3Key:
 │       ├─ [-] 3e778310b2cbd8520f60d2be4dea82a4fffc353e2827482f9fcc5eb015675baf.zip
 │       └─ [+] bd774a5670805a8e5ef789fb92fbe8a68221711128a21681e4d55aab7c92c93f.zip
 └─ [~] Metadata
     └─ [~] .aws:asset:path:
         ├─ [-] asset.3e778310b2cbd8520f60d2be4dea82a4fffc353e2827482f9fcc5eb015675baf
         └─ [+] asset.bd774a5670805a8e5ef789fb92fbe8a68221711128a21681e4d55aab7c92c93f
[~] AWS::SQS::Queue Convert-/ProcessingQueue ConvertProcessingQueueE8D6E023 
 └─ [~] VisibilityTimeout
     ├─ [-] 1800
     └─ [+] 900
[~] AWS::Lambda::Function Convert-/Lambda ConvertLambda3540DCCB 
 ├─ [~] Code
 │   └─ [~] .S3Key:
 │       ├─ [-] a2f4d8265c2468e1e72a93d6487d82a48af9a336e88edac230c9287af030fefc.zip
 │       └─ [+] e07fd11eb7b340c90ab3768d53b872baf2d76a26040408ba87b31682f2af3f4d.zip
 ├─ [~] MemorySize
 │   ├─ [-] 3584
 │   └─ [+] 2500
 ├─ [~] Timeout
 │   ├─ [-] 300
 │   └─ [+] 150
 └─ [~] Metadata
     └─ [~] .aws:asset:path:
         ├─ [-] asset.a2f4d8265c2468e1e72a93d6487d82a48af9a336e88edac230c9287af030fefc
         └─ [+] asset.e07fd11eb7b340c90ab3768d53b872baf2d76a26040408ba87b31682f2af3f4d

@github-actions
Copy link

github-actions bot commented May 4, 2021 

Stack wm
Resources
[~] AWS::Lambda::Function Api-/Lambda ApiLambdaB75D04FB 
 ├─ [~] Code
 │   └─ [~] .S3Key:
 │       ├─ [-] c070daac02489a748e9e0644a4457029e3a83e5040022b98ebd633daa7185557.zip
 │       └─ [+] 2a2dd2b026f1d171665207eb38bc3f350f5dd3ffa7de786ad8e4158b50154c8e.zip
 └─ [~] Metadata
     └─ [~] .aws:asset:path:
         ├─ [-] asset.c070daac02489a748e9e0644a4457029e3a83e5040022b98ebd633daa7185557
         └─ [+] asset.2a2dd2b026f1d171665207eb38bc3f350f5dd3ffa7de786ad8e4158b50154c8e
[~] Custom::CDKBucketDeployment Frontend-/DeployWebsite/CustomResource FrontendDeployWebsiteCustomResource1B4A6C7F 
 └─ [~] SourceObjectKeys
     └─ @@ -1,3 +1,3 @@
        [ ] [
        [-]   "8e2f46491c624e46a366b39f73b33d84b38bcf713f064d1ae042cde9d21a6278.zip"
        [+]   "9cccad051d1fae79347fff72b27206af81e9401057d07082c29f23f864a99715.zip"
        [ ] ]
[~] AWS::Lambda::Function InsertKeysToTimestream-/Lambda InsertKeysToTimestreamLambdaA07E952E 
 ├─ [~] Code
 │   └─ [~] .S3Key:
 │       ├─ [-] 3e778310b2cbd8520f60d2be4dea82a4fffc353e2827482f9fcc5eb015675baf.zip
 │       └─ [+] bd774a5670805a8e5ef789fb92fbe8a68221711128a21681e4d55aab7c92c93f.zip
 └─ [~] Metadata
     └─ [~] .aws:asset:path:
         ├─ [-] asset.3e778310b2cbd8520f60d2be4dea82a4fffc353e2827482f9fcc5eb015675baf
         └─ [+] asset.bd774a5670805a8e5ef789fb92fbe8a68221711128a21681e4d55aab7c92c93f
[~] AWS::SQS::Queue Convert-/ProcessingQueue ConvertProcessingQueueE8D6E023 
 └─ [~] VisibilityTimeout
     ├─ [-] 1800
     └─ [+] 900
[~] AWS::Lambda::Function Convert-/Lambda ConvertLambda3540DCCB 
 ├─ [~] Code
 │   └─ [~] .S3Key:
 │       ├─ [-] a2f4d8265c2468e1e72a93d6487d82a48af9a336e88edac230c9287af030fefc.zip
 │       └─ [+] ab3b65ed79995f18e83a239f94bd5f6c41c96cb05c54601582622483a076f960.zip
 ├─ [~] Timeout
 │   ├─ [-] 300
 │   └─ [+] 150
 └─ [~] Metadata
     └─ [~] .aws:asset:path:
         ├─ [-] asset.a2f4d8265c2468e1e72a93d6487d82a48af9a336e88edac230c9287af030fefc
         └─ [+] asset.ab3b65ed79995f18e83a239f94bd5f6c41c96cb05c54601582622483a076f960

@jonny-rimek jonny-rimek merged commit a164433 into prod May 4, 2021
@jonny-rimek jonny-rimek deleted the memory-leak branch May 4, 2021 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Goroutines are leaking memory
1 participant
@jonny-rimek