Gamma applied twice in "sdlayer2.c" #21
Comments
jonof
added a commit
that referenced
this issue
Jul 9, 2023
sdlayer2 behaved the opposite to winlayer and has been incorrect all this time. Expose the option to use system gamma ramp adjustment or not via a 'usegammabrightness' extern/osdvar. TODO: write 'usegammabrightness' to config TODO: do gamma in GL shader, paying attention to all the caveats WIP: needs to reset/apply the gamma curve when toggling the osdvar fixes #21
jonof
added a commit
that referenced
this issue
Feb 17, 2024
sdlayer2 behaved the opposite to winlayer and has been incorrect all this time. The engine now exposes the option to use gamma adjustment or the palette for brightness via a 'usegammabrightness' extern/osdvar. * 0 means use palette shade offset brightness like DOS did * 1 means apply a brightness curve in OpenGL fragment shaders * 2 means change the system gamma ramp The default is shader-based brightness. Recognised imperfection: setgamma() is almost identical in the two sdl/winlayer.c files, but because of the 8bit GL gubbins being the responsibility of the -layers to manage, putting the common gamma-set logic into engine.c would mean defining another cross-module interface just to poke gamma across the boundary. Note also, setbrightness() can take a null palette if nothing should change about the current palette except brightness. Refs #21
jonof
added a commit
that referenced
this issue
Feb 19, 2024
sdlayer2 behaved the opposite to winlayer and has been incorrect all this time. The engine now exposes the option to use gamma adjustment or the palette for brightness via a 'usegammabrightness' extern/osdvar. * 0 means use palette shade offset brightness like DOS did * 1 means apply a brightness curve in OpenGL fragment shaders * 2 means change the system gamma ramp The default is shader-based brightness, failing back to system gamma and then palette. Note also, setbrightness() can take a null palette if nothing should change about the current palette except brightness. Refs #21
|
You've now got a couple of options: OpenGL shader-based which is the new default, and palette-based as requested and is the last-ditch method. You can switch by opening the console/onscreen-display and typing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is first done with
curpalettefadedwhere the gamma is applied by the tables. Also called SDL_SetWindowBrightness with the same gamma.I would prefer to use the original tables, because in windowed mode SDL changes the brightness for all windows, not just the game window.
The text was updated successfully, but these errors were encountered: