Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

self.__n_miss counter starting with nmiss instead of 0 #21

Closed
SiddharthDey opened this issue Dec 20, 2023 · 1 comment
Closed

self.__n_miss counter starting with nmiss instead of 0 #21

SiddharthDey opened this issue Dec 20, 2023 · 1 comment

Comments

@SiddharthDey
Copy link
Contributor

The number of misses for a track is counted with the self.__nmiss attribute, but its initial value is defined as nmiss which is the maximum number of consecutive misses allowed for a track before it is deleted. But the nmiss is not used to check the max misses and the condition is hard-coded to 3 instead of using nmiss (line 38 of kalman_filter.py):

if self.__nmiss > 3:
   return False

If we do this, then when we create a new Kalman track at frame k-1 and then assume a missed detection at frame k, self.__nmiss becomes 4 instead of 1 and hence, the branch gets pruned.

I think we should maintain two separate attributes, self.__nmiss and self.__nmiss_max, and initialize them to 0 and nmiss respectively and modify the condition to:

if self.__nmiss > self.__nmiss_max:
   return False
@SiddharthDey SiddharthDey changed the title n_miss counter starting with 3 instead of 0 self.__n_miss counter starting with nmiss instead of 0 Dec 20, 2023
SiddharthDey added a commit to SiddharthDey/openmht that referenced this issue Dec 20, 2023
@jonperdomo
Copy link
Owner

Closed by PR #23 thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants