Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test the client, API improvements #9

Merged
merged 31 commits into from Oct 8, 2017
Merged

Test the client, API improvements #9

merged 31 commits into from Oct 8, 2017

Conversation

mbabker
Copy link
Contributor

@mbabker mbabker commented Oct 4, 2017

Pull Request for Issue #6

Summary of Changes

  • Adds a functional test class covering the LdapClient
  • Adds tracking state to make sure the connection is bound
  • Adds a destructor to make sure the connection is closed when the object destroyed
  • Adds checks to make sure the connection is established and bound when needed since we cannot lazy bind

Testing Instructions

Either put some trust in a green CI build or try to set up a LDAP server and use the client

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants