Correcting some errors for core package creation #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -65,6 +65,8 @@ protected function getInput() | |||
| $packages = LocaliseHelper::getPackages(); | |||
| $packages_options = array(); | |||
|
|
|||
| /** We took off the packages icons (due to bootstrap implementation) | |||
| * This may need review | |||
There was a problem hiding this comment.
For code that needs future review I would recommend to add a Todo statement:
* @Todo: this may need reviewBecause the todo statemets are indexed by the IDEs:
And we can find them easily later:
|
added |
javigomez
added a commit
that referenced
this pull request
Jun 5, 2014
Correcting some errors for core package creation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This saves all fields in the package xml, and lets create a core-compliant language pack.
It is not a final approach to the general packages creation where one should have the choice between a 3pd extension lang (or langs) file type pack and core.
(See http://docs.joomla.org/J2.5:Making_non-core_language_packs )
Also, for core packs, translator should have the choice to include css, js (in media) for example
Even with this patch we still have some issues for core packs as not all ini files are included (tpl, and also some files for no apparent reason: mod_version, mod_multilangstatus, main ini file.