Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate countMenuChildren #117

Merged
merged 2 commits into from
May 12, 2023
Merged

Deprecate countMenuChildren #117

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7e8f5a
Deprecate countMenuChildren
laoneo May 8, 2023
668be92
43
laoneo May 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion migrations/43-44/new-deprecations.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ This page is unfinished, please use the **Edit this Page** link at the bottom of

:::

#### Workflow rquires database and application
#### Workflow requires database and application

File: libraries/src/Workflow/Workflow.php
Replacement: The application and database will be mandatory
Expand All @@ -29,3 +29,12 @@ class Foo {
use Joomla\Database\DatabaseAwareTrait;
}
```

#### countMenuChildren in HtmlDocument is deprecated

File: libraries/src/Document/HtmlDocument.php
Replacement: Load the active menu item directly from the application and count the children with the php `count` function.
Example:
```php
$app->getMenu()->getActive() ? count($app->getMenu()->getActive()->getChildren()) : 0;
```