[4.0] com_content: correct incomplete group by clause (mistake: wrong branch) #13027

andrepereiradasilva · 2016-11-26T12:26:33Z

Pull Request for New Issue.

Summary of Changes

If you enable associations in language filter 4.0 branch is producing an sql error because of the group by clause.

Related to the more strict ONLY_FULL_GROUP_BY sql_mode added in 4.0 branch (#12494)

Testing Instructions

Mainly code review, but you can also

Use 4.0 branch
Enable language filter plugin and associations
Go to content -> articles you get an sql error
Apply patch, no error

Documentation Changes Required

None.

Changed the reqex for all unknown protocols. Removed the + character for the whitespace to solve a max_execution_timeout exception. If you have a large output document the regex '#\s+(src|href|poster)="(?!/|' . $protocols . '|\#|\')([^"]*)"#m' takes way to long. Supporting only one \s will do the trick as well. The result will be additional spaces between attributes, but this shouldn't harm.

* Delete unnecesary catslug from mod_related_items * remove whitespace * catslug depricated note * start comment with a capital letter * add blank line * Update helper.php * Update helper.php

* nested-form: Delete unnecesary catslug query from mod_related_items (joomla#8946)

* Correcting login/logout lang strings * Updating strings

…oomla#12656) * com_fields: Allow translation of field label via language string * better this way

…2454) * Uodating Hathor to use new Live and Upload for joomlaupdate * Changing float of #form-login * Adding min-height

…oomla#12879) * Using a neutral colour for multilingual buttons at installation time * Using a darker shade of blue * Reduce CSS, using wildcard

* update tooltip * update in the item view options

* Update web.php setHeader $replace previously did nothing other than delete a value - even when false it allowed a duplicate to be created which effectively replaces the original. This modification searches for an existing header with the same name and only inserts it if it doesn't already exist, or if $replace is true. * JApplicationWeb::setHeader behavior Fix Travis CI error regarding invalid foreach * JApplicationWeb::setHeader behavior Formatting changes * JApplicationWeb::setHeader behavior Formatting issues * Fix testSetHeader in line 1314 ��"$this->class->setHeader('foo', 'car');", the method is called without the $replace argument, meaning it uses the default of "false". The way headers are set, allowing a duplicate here means the header is replaced in JApplicationWeb::header. If $replace isn't enforced in setHeader then duplicates mean the header gets replaced anyway. The attempted entry is removed from the assertEquals test. * JApplicationWeb -setHeader and sendHeader upgrade Current Joomla header operation causes a duplicate header to replace an original header even when $replace = false. The replacement is a result of interaction between setHeader and sendHeader. setHeader happily adds duplicate entries when $replace = false sendHeader happily replaces headers because its default is to replace This commit alters both: setHeader now checks an internal list of headers which may only have one value. If the header is a single value only, the header array is updated only if $replace = true and the update is ignored otherwise If the header is not a single value, the header is replaced if $replace = true, otherwise it is added as a multiple value sendHeader now creates a new array of values, aggregating values under the header name. When the header is sent to the header() method, its value is imploded on ', ' * Returning test to original state this should be removed from the branch but I'm not sure how to do it. * JApplicationWeb::setHeader behavior Update to fix status header * JApplicationWeb -setHeader and sendHeader upgrade Fixing for test output * JApplicationWeb -setHeader and sendHeader upgrade formatting * JApplicationWeb -setHeader and sendHeader upgrade formatting * JApplicationWeb -setHeader and sendHeader upgrade formatting * JApplicationWeb -setHeader and sendHeader upgrade refinement - removed unnecessary parens * JApplicationWeb -setHeader and sendHeader upgrade performance enhancement * JApplicationWeb -setHeader and sendHeader upgrade performance enhancements, 2 fewer foreach iterations for the headers * JApplicationWeb -setHeader and sendHeader upgrade formatting fix * JApplicationWeb -setHeader and sendHeader upgrade Missed a variable change i sendHeader * JApplicationWeb -setHeader and sendHeader upgrade formatting fix * Update web.php * JApplicationWeb -setHeader and sendHeader upgrade fix formatting * JApplicationWeb -setHeader and sendHeader upgrade Adding ability to unset (remove) an existing header using $replace=true and $value=null setHeader('name', null, true) now removes the header entirely, where previous behavior would have sent the header with an empty value. * JApplicationWeb -setHeader and sendHeader upgrade formatting fix

* Get the correct height of the iframe * Making it more robust for all browsers

* Add Tag filter * Codestyle * add string * Updating XML file to use new string

) * new JLanguageHelper::getInstalledLanguages * some mroe improvs * correct deprecated comment * fix bug * cs * positive * strict * be sure there in an index for each client * check if file exists * remove extra ) * remove check

) * extension databasetable - set enabled to 0 by default * database update for existing sites * database update for mysql for existing sites

…ed (joomla#12815) * add menu type id to the model so we can use it on acl checks * add the correct acl check

…ing a new category (joomla#12820) * Update category.php * Update category.php

…mla#12826) * Update view.html.php * Update default.php

* make google authenticator a link and add freeotp as an example * add intro * remove google * another freeotp link

* return translated number * ups * cs * fix unit tests * fix last unit tests * minor cs

…closed. (joomla#12928)

* remove tab on meta charset * Update code

* Fix Undefined offset * tabs/spacing * If someone has faked an article id - dont show trace, show an error * make travis happy * make travis happy * travis I hate you * tab/space hell * tab/spaces hell * changes as requested * remove the $language var as per comment

* Update menu.php * Update item.php

The feature item filter was already available for the mod_articles_latest module, but that is just a list. All code was slightly modified from the mod_articles_latest module. Language File - Added three variables (description, lable and value) Helper - Copy and pasted the switch from mod_articles_latest (same parameter ordering too) Parameter file - Added field after order (mirroring _latest)

Please review https://issues.joomla.org/tracker/joomla-cms/12948 for details

Well done @dgt41

Export of Banners Tracks Does Not Export the Banner Name

* Remove duplicate "Google Authenticator" and a space within an anchor tag. * Added a missing link to Google Authenticator

Summary of Changes Fixed a small typo in the comment. enabed > enabled Testing Instructions Code review Documentation Changes Required None

…se. (joomla#13010) * Coding standards. The PHP constants true, false, and null MUST be in lower case. * Update restore.php

andrepereiradasilva · 2016-11-26T12:43:29Z

wrong branch ... will remake

joomla-cms-bot · 2017-05-02T06:54:12Z

Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/13027

hordijk and others added 30 commits November 12, 2016 16:14

Don't skip JHtml's bootstrap call for override check (joomla#12854)

af98a75

Delete unnecesary catslug query from mod_related_items (joomla#8946)

90d218b

* Delete unnecesary catslug from mod_related_items * remove whitespace * catslug depricated note * start comment with a capital letter * add blank line * Update helper.php * Update helper.php

Delete unnecesary catslug query from mod_related_items (joomla#8946)

c83d6c4

* Delete unnecesary catslug from mod_related_items * remove whitespace * catslug depricated note * start comment with a capital letter * add blank line * Update helper.php * Update helper.php

Merge branch 'nested-form' into staging

eb4ddb4

* nested-form: Delete unnecesary catslug query from mod_related_items (joomla#8946)

3.7.0 : Correcting login/logout lang strings (joomla#12337)

fa5aa78

* Correcting login/logout lang strings * Updating strings

Update item.php (joomla#12825)

631501d

Removing the notice when a global value is not found. (joomla#12858)

9196431

com_fields: allowing custom field Label to be translated by a string (j…

1a21f17

…oomla#12656) * com_fields: Allow translation of field label via language string * better this way

Updating Hathor to use new Live and Upload for joomlaupdate (joomla#1…

15c3fc4

…2454) * Uodating Hathor to use new Live and Upload for joomlaupdate * Changing float of #form-login * Adding min-height

Using a neutral colour for multilingual buttons at installation time (j…

3ac49e0

…oomla#12879) * Using a neutral colour for multilingual buttons at installation time * Using a darker shade of blue * Reduce CSS, using wildcard

com_newsfeed update tooltip (joomla#12892)

c28decb

* update tooltip * update in the item view options

If the label is empty set it from the title automatically (joomla#12885)

52833e3

Resize to the correct height of the iframe (joomla#11554)

e6b85d1

* Get the correct height of the iframe * Making it more robust for all browsers

Subform.Repeatable styling (joomla#12634)

d4a5223

Add Tag filter (joomla#12640)

0ef219f

* Add Tag filter * Codestyle * add string * Updating XML file to use new string

[Smart Search] Log peak memory usage in web indexer (joomla#12680)

154c3fd

Remove not used option (joomla#12699)

b50e748

[Smart Search] Fix for tags issue joomla#10122 (joomla#12745)

af8fbde

database table #__extensions - Set enabled to 0 by default (joomla#12753

20557af

) * extension databasetable - set enabled to 0 by default * database update for existing sites * database update for mysql for existing sites

the component name is com_contact not com_contacts (joomla#12797)

1b5b6ef

Update view.html.php (joomla#12800)

c584c48

[ACL] [com_menus items view] Correct check when "All Menus" is select…

9416db2

…ed (joomla#12815) * add menu type id to the model so we can use it on acl checks * add the correct acl check

[ACL] [new category] Correct invalid core.edit.state check when creat…

ea89356

…ing a new category (joomla#12820) * Update category.php * Update category.php

Update groupparent.php (joomla#12824)

8bc8984

[ACL] [com_fields fields view] Correct when display batch button (joo…

4c8344d

…mla#12826) * Update view.html.php * Update default.php

Update field.php (joomla#12827)

2156baf

google authenticator plugin description (joomla#12833)

8b81b71

* make google authenticator a link and add freeotp as an example * add intro * remove google * another freeotp link

andrepereiradasilva and others added 20 commits November 17, 2016 21:08

Update edit.php (joomla#12818)

05d5fb3

[JHtmlNumber::bytes] Format number according to language (joomla#12929)

923c361

* return translated number * ups * cs * fix unit tests * fix last unit tests * minor cs

JSession patched to set session _state to 'inactive' when session is …

117a9a1

…closed. (joomla#12928)

remove tab on meta charset (joomla#12895)

bd7f1c4

* remove tab on meta charset * Update code

Set correct component id for system links (joomla#12938)

1586cd0

* Update menu.php * Update item.php

a11y regression fix (joomla#12935)

b2f1659

fix them all (joomla#12943)

010742e

fix rues get data (joomla#12763)

b95b146

Export of Banners Tracks Does Not Export the Banner Name

b7d57cd

Please review https://issues.joomla.org/tracker/joomla-cms/12948 for details

New DateTime picker (replaces calendar) (joomla#11138)

0074a39

Well done @dgt41

Error in sr-YU installation ini file (joomla#12984)

354d178

Merge pull request joomla#12951 from imanickam/patch-2

e8ba87c

Export of Banners Tracks Does Not Export the Banner Name

code style changes (joomla#12986)

f94086d

Correcting strings in TFA Google plugin (joomla#12980)

81142af

* Remove duplicate "Google Authenticator" and a space within an anchor tag. * Added a missing link to Google Authenticator

Fixed typo in comment (joomla#12992)

3f38a80

Summary of Changes Fixed a small typo in the comment. enabed > enabled Testing Instructions Code review Documentation Changes Required None

Removing duplicated AS in sql query (joomla#13006)

0c0884f

Coding style. PHP constants true, false, and null MUST be in lower ca…

fda5272

…se. (joomla#13010) * Coding standards. The PHP constants true, false, and null MUST be in lower case. * Update restore.php

Update articles.php

9ba196b

joomla-cms-bot added the PR-staging label Nov 26, 2016

andrepereiradasilva changed the base branch from staging to 4.0-dev November 26, 2016 12:42

andrepereiradasilva closed this Nov 26, 2016

andrepereiradasilva deleted the patch-39 branch November 26, 2016 12:43

joomla-cms-bot added the PR-4.0-dev label Nov 26, 2016

andrepereiradasilva changed the title ~~[4.0] com_content: correct incomplete group by clause~~ [4.0] com_content: correct incomplete group by clause (mistake: wrong branch) Nov 26, 2016

joomla-cms-bot removed PR-4.0-dev labels May 2, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[4.0] com_content: correct incomplete group by clause (mistake: wrong branch) #13027

[4.0] com_content: correct incomplete group by clause (mistake: wrong branch) #13027

andrepereiradasilva commented Nov 26, 2016 •

edited by joomla-cms-bot

andrepereiradasilva commented Nov 26, 2016

joomla-cms-bot commented May 2, 2017

[4.0] com_content: correct incomplete group by clause (mistake: wrong branch) #13027

[4.0] com_content: correct incomplete group by clause (mistake: wrong branch) #13027

Conversation

andrepereiradasilva commented Nov 26, 2016 • edited by joomla-cms-bot

Summary of Changes

Testing Instructions

Documentation Changes Required

andrepereiradasilva commented Nov 26, 2016

joomla-cms-bot commented May 2, 2017

andrepereiradasilva commented Nov 26, 2016 •

edited by joomla-cms-bot