Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Joomla Update "Find Updates" Issue #13428

Closed
PhilETaylor opened this issue Dec 30, 2016 · 18 comments
Closed

Joomla Update "Find Updates" Issue #13428

PhilETaylor opened this issue Dec 30, 2016 · 18 comments

Comments

@PhilETaylor
Copy link
Contributor

PhilETaylor commented Dec 30, 2016

Steps to reproduce the issue

Install a load of crap extensions (or just Virtuemart and a load of other crap). Or a site with 100 update sites...

(or be on a crap server that is blocking outgoing traffic in such a way that an outgoing http request hangs instead of getting a connection denied message)

Go to Extensions -> Update -> Find Updates

Note that if any one update site is slow or never ends then the page times out eventually or hangs for ever and ever.

Expected result

Expect a list of updates available

Actual result

Page just hangs because one or more update sites are pathetically slow or dead.

System information (as much as possible)

Joomla 3.6.5

Additional comments

Each update site check should be time boxed, or run in isolation (maybe in a separate ajax thread) so that one doesnt effect all.

@PhilETaylor

This comment was marked as abuse.

@PhilETaylor

This comment was marked as abuse.

@PhilETaylor

This comment was marked as abuse.

@nibra
Copy link
Member

nibra commented Mar 24, 2017

their 404's are just highlighting the root issue in Joomla installer

@PhilETaylor, what behaviour would you expect instead (beside waiting 2 seconds instead of 20)?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13428.

@RedEvo
Copy link

RedEvo commented Mar 24, 2017

I would expect that all updates would be run in isolation and even maybe in parallel, with individual timeouts, per update, one per http request to avoid timeouts on servers

@dgrammatiko
Copy link
Contributor

In J4 we can use promises and chain all these requests, so they would be async and the failures could be handled much better

@PhilETaylor

This comment was marked as abuse.

@dgrammatiko
Copy link
Contributor

I'll test the PR if you create it :)

@PhilETaylor

This comment was marked as abuse.

@mbabker
Copy link
Contributor

mbabker commented Mar 27, 2017

Nobody's saying it's not an issue. But for those who do PRs, either this isn't an "interesting" issue they want to tackle or they don't have the technical skill set to do anything with it.

@dgrammatiko
Copy link
Contributor

or too busy with other 💩

@PhilETaylor

This comment was marked as abuse.

@mbabker
Copy link
Contributor

mbabker commented Mar 27, 2017

If you keep closing legitimate issues then they're never going to be tackled to begin with.

@PhilETaylor

This comment was marked as abuse.

@PhilETaylor

This comment was marked as abuse.

@mbabker
Copy link
Contributor

mbabker commented Mar 27, 2017

The book is here on GitHub. There isn't a magical list elsewhere of known issues that might get tackled one day if someone is interested.

@PhilETaylor

This comment was marked as abuse.

@mbabker
Copy link
Contributor

mbabker commented Mar 27, 2017

If we were to list all of our annoyances with Joomla in GH then the issues list would be huge ;-)

That sounds like someone I groan at every time they publish a blog or tweet stream groaning about Joomla performance, they shut up every time I tell them to log an issue instead of groaning 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants