-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Joomla Update "Find Updates" Issue #13428
Comments
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
@PhilETaylor, what behaviour would you expect instead (beside waiting 2 seconds instead of 20)? This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13428. |
I would expect that all updates would be run in isolation and even maybe in parallel, with individual timeouts, per update, one per http request to avoid timeouts on servers |
In J4 we can use promises and chain all these requests, so they would be async and the failures could be handled much better |
This comment was marked as abuse.
This comment was marked as abuse.
I'll test the PR if you create it :) |
This comment was marked as abuse.
This comment was marked as abuse.
Nobody's saying it's not an issue. But for those who do PRs, either this isn't an "interesting" issue they want to tackle or they don't have the technical skill set to do anything with it. |
or too busy with other 💩 |
This comment was marked as abuse.
This comment was marked as abuse.
If you keep closing legitimate issues then they're never going to be tackled to begin with. |
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
The book is here on GitHub. There isn't a magical list elsewhere of known issues that might get tackled one day if someone is interested. |
This comment was marked as abuse.
This comment was marked as abuse.
That sounds like someone I groan at every time they publish a blog or tweet stream groaning about Joomla performance, they shut up every time I tell them to log an issue instead of groaning 😉 |
Steps to reproduce the issue
Install a load of crap extensions (or just Virtuemart and a load of other crap). Or a site with 100 update sites...
(or be on a crap server that is blocking outgoing traffic in such a way that an outgoing http request hangs instead of getting a connection denied message)
Go to Extensions -> Update -> Find Updates
Note that if any one update site is slow or never ends then the page times out eventually or hangs for ever and ever.
Expected result
Expect a list of updates available
Actual result
Page just hangs because one or more update sites are pathetically slow or dead.
System information (as much as possible)
Joomla 3.6.5
Additional comments
Each update site check should be time boxed, or run in isolation (maybe in a separate ajax thread) so that one doesnt effect all.
The text was updated successfully, but these errors were encountered: