Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CS] Round 3 Code Style fixes for Superfluous Whitespace #19163

Merged
merged 1 commit into from
Dec 25, 2017

Conversation

photodude
Copy link
Contributor

Pull Request for Issue found Superfluous Whitespace.

Summary of Changes

Third and final round of fixes for Superfluous Whitespace

  • Whitespace found at end of line
  • Functions must not contain multiple empty lines in a row; found 2 empty lines

Automatically fixed with Joomla code standards 2.0.0 PHPCS2-alpha2 fixers

None of the manual only fixes have been applied

Testing Instructions

Merge by code review

Expected result

code style has been applied as listed above, old code style testing on drone does not error.

Actual result

code style had not been applied. Autofixers from the Joomla code standards 2.0.0 PHPCS2 alpha2 were used to implement fixable code style

Documentation Changes Required

none

- Whitespace found at end of line
- Functions must not contain multiple empty lines in a row; found 2
empty lines
@Quy
Copy link
Contributor

Quy commented Dec 24, 2017

I have tested this item ✅ successfully on c6043e3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19163.

@wilsonge wilsonge merged commit d9b7c00 into joomla:staging Dec 25, 2017
@wilsonge wilsonge added this to the Joomla 3.8.4 milestone Dec 25, 2017
@photodude photodude deleted the PHPCS2-SuperfluousWhitespace3 branch December 25, 2017 05:13
photodude added a commit to photodude/joomla-cms that referenced this pull request Dec 25, 2017
- Whitespace found at end of line
- Functions must not contain multiple empty lines in a row; found 2
empty lines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants