Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issueing a request for a deleted banner results in network errors #20325

Closed
norman27 opened this issue May 9, 2018 · 4 comments
Closed

Issueing a request for a deleted banner results in network errors #20325

norman27 opened this issue May 9, 2018 · 4 comments

Comments

@norman27
Copy link

norman27 commented May 9, 2018

Steps to reproduce the issue

  • Create a banner in the component (let's say ID=123)
  • (now the url /component/banners/click/123 might be indexed by google or used somewhere else)
  • Delete this banner completely
  • Try to request /component/banners/click/123

Expected result

Return a HTTP status 404

Actual result

this will result in an error message generated by the browser regarding broken contents. the return HTTP status is 303 with header Location: http://

System information (as much as possible)

installed version 3.8.7

Additional comments

At some point this will also be reported to you via the google search console.

@ghost
Copy link

ghost commented May 16, 2018

Can please anyone answer as this issue has since one Week Status "New"?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20325.

@Quy
Copy link
Contributor

Quy commented May 31, 2018

Issue confirmed. In PHP error log:

PHP Notice: Trying to get property 'track_clicks' of non-object in \components\com_banners\models\banner.php on line 61
PHP Notice: Trying to get property 'clickurl' of non-object in \components\com_banners\models\banner.php on line 197

@joomla-cms-bot
Copy link

Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/20325

@Quy
Copy link
Contributor

Quy commented Jun 5, 2018

Please test PR #20664


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20325.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants