Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Schedule featured articles #25978

Closed
wants to merge 8,311 commits into from
Closed

Conversation

eshiol
Copy link
Contributor

@eshiol eshiol commented Aug 22, 2019

Pull Request for Issue #13596.
J4 rebased PR #18052

Summary of Changes

Added two fields in the article editor featured_up (Start Featured) and featured_down (End Featured)
Cattura
An article is featured if featured is yes and (featured_up is null or is less than or is equal to now) and (featured_down is null or is greater than or is equal to now)

Testing Instructions

create 5 articles:

  1. not featured
  2. featured, featured_up = null, featured_down = null
  3. featured, featured_up = tomorrow, featured_down = null
  4. featured, featured_up = null, featured_down = yesterday
  5. featured, featured_up = yesterday, featured_down = tomorrow
    Create an Articles » Featured Articles menu item
    Create a News Flash module and set the option Featured Articles to Only show Featured Articles.

Expected result

Only the articles 2 and 5 will be shown in the Articles » Featured Articles menu item and in the News Flash module.

Actual result

Documentation Changes Required

HLeithner and others added 30 commits July 23, 2019 19:14
Adds a label to the client, language and item type selectors in com_associations, comm_menus and com_languages
Co-Authored-By: Brian Teeman <brian@teeman.net>
Co-Authored-By: Brian Teeman <brian@teeman.net>
Co-Authored-By: Brian Teeman <brian@teeman.net>
Co-Authored-By: Brian Teeman <brian@teeman.net>
…elease

# Conflicts:
#	administrator/components/com_finder/tmpl/index/default.php
Simple PR to remove a duplicate block of code. Testing by code review
When viewing a user profile on the frontend you see the text
"No information entered" on any of the basic settings that have not been changed

Far better to say "Website default" as at least that way there is no confusion to the user. In the form they "selected" the -use default - option so to their understanding they have made a selection
SharkyKZ and others added 22 commits August 19, 2019 00:32
…oomla#25906)

* [4.0][backend template] Create opacity for disabled top menu items

* Adding pointer-events
PR for #25874t
Apply Cursor not allowed to the searchtools buttons to be consistent with the toolbar buttons
the string TPL_BACK_TO_CONTROL_PANEL was removed in error in the template repo. This PR puts it back and at the same ttime takes the opportunity to name it correctly as TPL_ATUM_BACK_TO_CONTROL_PANEL

The string is used for the link on the logo in the top corner
* fix wrong group by

* fix wrong group by

* fix wrong group by

* lang_code

* lang_code

* lang_code
the string TPL_BACK_TO_CONTROL_PANEL was removed in error in the template repo. This PR puts it back and at the same ttime takes the opportunity to name it correctly as TPL_ATUM_BACK_TO_CONTROL_PANEL

The string is used for the link on the logo in the top corner
@eshiol
Copy link
Contributor Author

eshiol commented Aug 22, 2019

commit into joomla:staging by mistake

@eshiol eshiol closed this Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet