-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Schedule featured articles #25978
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a label to the client, language and item type selectors in com_associations, comm_menus and com_languages
Co-Authored-By: Brian Teeman <brian@teeman.net>
Co-Authored-By: Brian Teeman <brian@teeman.net>
Co-Authored-By: Brian Teeman <brian@teeman.net>
Co-Authored-By: Brian Teeman <brian@teeman.net>
…elease # Conflicts: # administrator/components/com_finder/tmpl/index/default.php
Simple PR to remove a duplicate block of code. Testing by code review
When viewing a user profile on the frontend you see the text "No information entered" on any of the basic settings that have not been changed Far better to say "Website default" as at least that way there is no confusion to the user. In the form they "selected" the -use default - option so to their understanding they have made a selection
…oomla#25906) * [4.0][backend template] Create opacity for disabled top menu items * Adding pointer-events
PR for #25874t Apply Cursor not allowed to the searchtools buttons to be consistent with the toolbar buttons
the string TPL_BACK_TO_CONTROL_PANEL was removed in error in the template repo. This PR puts it back and at the same ttime takes the opportunity to name it correctly as TPL_ATUM_BACK_TO_CONTROL_PANEL The string is used for the link on the logo in the top corner
* fix wrong group by * fix wrong group by * fix wrong group by * lang_code * lang_code * lang_code
the string TPL_BACK_TO_CONTROL_PANEL was removed in error in the template repo. This PR puts it back and at the same ttime takes the opportunity to name it correctly as TPL_ATUM_BACK_TO_CONTROL_PANEL The string is used for the link on the logo in the top corner
eshiol
requested review from
laoneo,
rdeutz,
wilsonge and
zero-24
as code owners
August 22, 2019 21:00
commit into joomla:staging by mistake |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #13596.
J4 rebased PR #18052
Summary of Changes
Added two fields in the article editor featured_up (Start Featured) and featured_down (End Featured)
An article is featured if featured is yes and (featured_up is null or is less than or is equal to now) and (featured_down is null or is greater than or is equal to now)
Testing Instructions
create 5 articles:
Create an Articles » Featured Articles menu item
Create a News Flash module and set the option Featured Articles to Only show Featured Articles.
Expected result
Only the articles 2 and 5 will be shown in the Articles » Featured Articles menu item and in the News Flash module.
Actual result
Documentation Changes Required