Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Add period to the success message #36172

Merged
merged 1 commit into from
Dec 1, 2021
Merged

Conversation

Quy
Copy link
Contributor

@Quy Quy commented Dec 1, 2021

Testing Instructions

Go to System >Site Modules
Edit a module.
Click Save & Close button.
See success message.

Perform similar steps to Plugins where the success message ends with a period.

Actual result BEFORE applying this Pull Request

Message has no period.

Expected result AFTER applying this Pull Request

Message ends with a period.

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.0-dev labels Dec 1, 2021
@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 0a15571


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36172.

@toivo
Copy link
Contributor

toivo commented Dec 1, 2021

I have tested this item ✅ successfully on 0a15571

Tested successfully in 4.0.5 rc using Wampserver 3.2.6 on Windows 10 with PHP 8.1.0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36172.

@drmenzelit
Copy link
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36172.

@drmenzelit drmenzelit removed Language Change This is for Translators PR-4.0-dev labels Dec 1, 2021
@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 1, 2021
@richard67 richard67 added Language Change This is for Translators PR-4.0-dev labels Dec 1, 2021
@chmst chmst added this to the Joomla 4.0.5 milestone Dec 1, 2021
@chmst chmst merged commit 934a543 into joomla:4.0-dev Dec 1, 2021
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Dec 1, 2021
@chmst
Copy link
Contributor

chmst commented Dec 1, 2021

thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants