-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.0] Symfony php80 and php81 polyfills not present in packages but on a git clone #40290
Comments
@Fedik Do you have an idea how we can fix that? |
I can confirm this. |
Of course we could fix that by removing the polyfills from the deleted files and folders lists in script.php so they will not be deleted on update (or when using the "Update Structure" button), but I think we should fix the real issue that these polyfills and another one for php72 are still used by some development dependencies on a git clone. |
Ah, I wrong understood, so error with files update. How it was managed in past when dependency removed, or it a first case in our history? :) |
The libraries/vendor folder doesn't exists in git. in case I would suspect that a 3rd party dependency requires the polyfill.. |
we have had something similar to this before with ldap. |
I created a PR which should fix this #40293 |
This comment was marked as outdated.
This comment was marked as outdated.
I'm closing this since we have a PR @richard67 @degobbis can you test #40293 please |
Steps to reproduce the issue
composer install
andnpm ci
.Result: The folders exist,
Expected result
Nothing happens.
Actual result
Blank page. In PHP error log:
PHP Fatal error: Uncaught Error: Failed opening required '/home/richard/lamp/public_html/joomla-cms-5.0-dev/libraries/vendor/composer/../symfony/polyfill-php80/bootstrap.php'
System information (as much as possible)
PHP 8.1, 5.0-dev branch on a git clone.
Additional comments
With PR #39968 , the symphony polyfills "polyfill-php80" and "polyfill-php81" were added as explicit dependencies to 4.2-dev so they are packaged into the 4.2.9 installation and update packages.
On 5.0-dev these polyfills should not be necessary because 5.0 requires PHP 8.1. And these polyfills are also not in the installation and update packages for 5.0-dev, that's ok and that's why they have been added to the list of deleted files in script.php with PR #40246 .
But on a git clone when running
composer install
it seems that they are added as an indirect dependency by some other dependency.And so they are also added to the autoloader file "libraries/vendor/composer/autoload_real.php".
If you now use the database checker's "Update Structure" button, it also runs the deletion of files and folders in script.php, and this breaks autoloading.
This does not happen when you are not on a git clone but use the latest 5.0-dev nightly build installation package and make a new installation with that package.
The text was updated successfully, but these errors were encountered: