Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP polyfills as explicit dependency #39968

Merged
merged 4 commits into from
Mar 13, 2023
Merged

Conversation

Fedik
Copy link
Member

@Fedik Fedik commented Feb 28, 2023

Pull Request for Issue #39954

Summary of Changes

Added symfony/polyfill-php80 and symfony/polyfill-php81 to composer json.
They already was in requirements, but implicitly.

Testing Instructions

Apply patch, run composer install, make sure all works as before.

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed

@HLeithner
Copy link
Member

drone failed

@HLeithner
Copy link
Member

can we pin this to the exact version please, then we don't have any changes to joomla it self (the changes in the lib are only codestyle and readme update, so no relevant code changes).

in 4.3 we already use the latest version so nothing needs to be changed in this branch.

@Fedik
Copy link
Member Author

Fedik commented Mar 1, 2023

I tried exact version, but composer complain that it do not see symfony/polyfill-php81 in lock file, or dron fail.
So I have no idea, and just updated these two 😉

@Hackwar
Copy link
Member

Hackwar commented Mar 4, 2023

If there is a polyfill for 7.3, 8.0 and 8.1, is there also one for 7.4?

@Fedik
Copy link
Member Author

Fedik commented Mar 4, 2023

Yes there is https://github.com/symfony/polyfill-php74
But I do not think that we use any of these 3 methods 😉

@Fedik
Copy link
Member Author

Fedik commented Mar 11, 2023

Maybe I better move it to 4.3, or?

@HLeithner
Copy link
Member

@roland-d and @fancyFranci this is missing for 4.2.9

@fancyFranci fancyFranci merged commit 5025b57 into joomla:4.2-dev Mar 13, 2023
@fancyFranci
Copy link
Contributor

Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants