-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP polyfills as explicit dependency #39968
Conversation
drone failed |
can we pin this to the exact version please, then we don't have any changes to joomla it self (the changes in the lib are only codestyle and readme update, so no relevant code changes). in 4.3 we already use the latest version so nothing needs to be changed in this branch. |
I tried exact version, but composer complain that it do not see |
If there is a polyfill for 7.3, 8.0 and 8.1, is there also one for 7.4? |
Yes there is https://github.com/symfony/polyfill-php74 |
Maybe I better move it to 4.3, or? |
@roland-d and @fancyFranci this is missing for 4.2.9 |
Thanks! :) |
Pull Request for Issue #39954
Summary of Changes
Added
symfony/polyfill-php80
andsymfony/polyfill-php81
to composer json.They already was in requirements, but implicitly.
Testing Instructions
Apply patch, run
composer install
, make sure all works as before.Link to documentations
Please select: