Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0] Update deleted files list in script.php to recent changes in the 5.0-dev branch #40246

Merged

Conversation

richard67
Copy link
Member

Pull Request for Issue # .

Summary of Changes

This pull request (PR) updates the lists of files and folders to be deleted on update in file "administrator/components/com_admin/script.php" to recent changes in the 5.0-dev branch.

  • New 4.x update SQL scripts are added to the deleted files list.
  • File '/libraries/vendor/google/recaptcha/ARCHITECTURE.md' is added to the deleted files list due to a dependency update.
  • Files and folders of symfony polyfills for unsupported PHP versions are added to the lists.
  • Files and folders from the symfony/console dependency are removed from the lists as they have been added back to the package by a dependency update.

Testing Instructions

Code review.

Or if you want to make a real test, update the last 4.4 nightly build to the last 5.0 nightly build to get the actual result, and update the last 4.4 nightly build to the update package built by Drone for this PR to get the expected result. Then compare the result with the result of a new installation with the full installation package.

Actual result BEFORE applying this Pull Request

The files and folders mentioned above as added to the lists are still present after updating from the last 4.4 nightly build.

Files and folders of the symfony/console dependency which are present in the full installation package are deleted with the update.

Expected result AFTER applying this Pull Request

The files and folders mentioned above as added to the lists have been deleted after updating from the last 4.4 nightly build.

Files and folders of the symfony/console dependency which are present in the full installation package are also present after the the update.

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed

  • No documentation changes for manual.joomla.org needed

@richard67
Copy link
Member Author

Ping @HLeithner .

@wilsonge wilsonge merged commit c864bf3 into joomla:5.0-dev Mar 30, 2023
@wilsonge
Copy link
Contributor

Thankyou!

@wilsonge wilsonge added this to the Joomla! 5.0 milestone Mar 30, 2023
@richard67 richard67 deleted the 5.0-dev-deleted-files-and-folders_2023-03-12 branch March 30, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants