-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SVG support #13499
SVG support #13499
Conversation
What are those changes in the autoloading files? Those look wrong to me. |
Dimitris is on an older version of composer :) It's regressing the autoload files back from composer 1.3.x to 1.2.x |
I sea 😜, will update that in a bit... |
Also Joomla is not supporting uploading of webp images... |
I have tested this item ✅ successfully on e4fd085 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13499. |
@uglyeoin one easy way to test the uploaded file is by pointing your browser to the path of the svg e.g. |
I have tested this item ✅ successfully on e4fd085 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13499. |
I have tested this item ✅ successfully on e4fd085 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13499. |
@ghazal I guess so. I have tested it successfully, but I have not tested the security side of things. I guess I need an insecure SVG in order to do so. I assume the other tests took this into account? |
@dgt41 perhaps you could supply an SVG for people to test with? |
Pull Request for Issue # .
Summary of Changes
This PR enables svg uploads and introduces a sanitiser for svg files
Sanitizer source: https://github.com/darylldoyle/svg-sanitizer
It is missing some db needed updates, will do them if it gets approved
Testing Instructions
Legal Extensions (File Types)
withTry to upload an svg file
Preview
Documentation Changes Required
NOTES
I hope that this clears up my intentions here (speed up the process by involving more people)
This change is