Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notice error with advanced seo and featured articles #201

Closed
wants to merge 1 commit into from
Closed

Notice error with advanced seo and featured articles #201

wants to merge 1 commit into from

Conversation

bembelimen
Copy link
Contributor

If you activate the sef_advanced_link option (with a plugin or by temporary hardcode it in the router itself, see line 208) you get a notice error by following this steps:

  1. Use an empty Joomla! installation for the best test environment (so other menu links will not "fix" the bug)
  2. Create a com_content article
  3. Set the article as "featured"
  4. Go to the default frontpage home link
  5. Click on the article
  6. Notice: Undefined index: id in components\com_content\router.php on line 278
  7. Apply pull request
  8. Check again

Why do you get this notice error?
Because featured blog links have no "id" as request parameter.

@infograf768
Copy link
Member

This option is not used in core. It is a remnant of an attempt to get better SEO in a pre-1.6 stable version.
Bugsquad tests have shown that using this may have weird results.

If it can be demonstrated that this is the main culprit for the option, generally speaking, please open a tracker on joomlacode.

@bembelimen
Copy link
Contributor Author

Hello,

do you know any tracker items or anything where I can find the problems with this function?

@nicksavov
Copy link
Contributor

Hi Bembelimen,

Sorry, I'm not aware of there being documentation for it. See the following discussion for more information:
https://groups.google.com/forum/?fromgroups=#!topic/joomla-dev-cms/ESxdBp0JkgA

@brianteeman
Copy link
Contributor

Thanks for your contribution - At this time we are only using github as the place to submit code fixes, the actual reporting of issues and testing fixes is still taking place on Joomlacode.

As it has been some time since you opened this issue can you please confirm that it is still valid with the current Master or Joomla 3.2 beta. If it is no longer valid then please can you close this issue. Otherwise please can you:

  1. Open an item on the Joomlacode tracker in the appropriate area.

CMS Bug Reports: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemBrowse&tracker_id=8103

CMS Feature Requests: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemBrowse&tracker_id=8549

  1. After submitting the item to the Joomlacode tracker, add a link to the Joomlacode tracker item here and make sure that you add a link to this GitHub issue or pull request on the joomlacode tracker item.

@bembelimen bembelimen closed this Nov 2, 2013
wilsonge pushed a commit that referenced this pull request Jun 4, 2017
* Image action icons for grid

* Responsive

* Always display icons at < 1180px
hans2103 pushed a commit to hans2103/joomla-cms that referenced this pull request Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants