[4.0] New Backend Template #21006
[4.0] New Backend Template #21006
Conversation
Merge from 4.0-dev branch
Merge joomla-cms/4.0-dev
Merge joomla-cms
Start login page redesign
…into button-style
fix the scss compiler
…into button-style
Sync with joomla-cms repo
…into button-style
Sync with joomla-cms repo
…into button-style
| }(HTMLElement)); | ||
| })(); | ||
|
|
||
| },{}]},{},[1]); |
There was a problem hiding this comment.
Block must not be padded by blank lines padded-blocks
A space is required after ',' comma-spacing
Expected a line break before this closing brace object-curly-newline
A space is required before '}' object-curly-spacing
|
|
||
| return _class; | ||
| }(HTMLElement)); | ||
| })(); |
There was a problem hiding this comment.
Expected indentation of 2 spaces but found 0 indent
| }]); | ||
|
|
||
| return _class; | ||
| }(HTMLElement)); |
There was a problem hiding this comment.
Expected indentation of 4 spaces but found 1 tab indent
Unexpected tab character no-tabs
| } | ||
| }]); | ||
|
|
||
| return _class; |
There was a problem hiding this comment.
Expected indentation of 6 spaces but found 2 tabs indent
Unexpected tab character no-tabs
| element.dispatchEvent(OriginalCustomEvent); | ||
| element.removeEventListener(eventName, element); | ||
| } | ||
| }]); |
There was a problem hiding this comment.
Expected indentation of 6 spaces but found 2 tabs indent
Unexpected tab character no-tabs
|
|
||
| }, { | ||
| key: 'dispatchCustomEvent', | ||
| value: function dispatchCustomEvent(eventName, element, related) { |
There was a problem hiding this comment.
Expected indentation of 8 spaces but found 3 tabs indent
Unexpected tab character no-tabs
| /* Method to dispatch events */ | ||
|
|
||
| }, { | ||
| key: 'dispatchCustomEvent', |
There was a problem hiding this comment.
Expected indentation of 8 spaces but found 3 tabs indent
Unexpected tab character no-tabs
|
|
||
| /* Method to dispatch events */ | ||
|
|
||
| }, { |
There was a problem hiding this comment.
Expected indentation of 6 spaces but found 2 tabs indent
Unexpected tab character no-tabs
| return el; | ||
| } | ||
|
|
||
| /* Method to dispatch events */ |
There was a problem hiding this comment.
Expected indentation of 8 spaces but found 3 tabs indent
Unexpected tab character no-tabs
| value: function findAncestor(el, tagName) { | ||
| while ((el = el.parentElement) && el.nodeName.toLowerCase() !== tagName) {} | ||
| return el; | ||
| } |
There was a problem hiding this comment.
Expected indentation of 8 spaces but found 3 tabs indent
Unexpected tab character no-tabs
Missing trailing comma comma-dangle
|
Someone tell me it's an intentional decision to not link to the module manager ANYWHERE but the control panel quick icon please. |
|
@coolcat-creations I just updated an existing test site via eclipse. Anything I should do? |
|
@infograf768 - as @wilsonge stated in the PR it's absolutely not in the state to be finished ... |
|
@mbabker the menu transformation is not complete atm! There are still items that need to be removed from the menu and others that need to be added (eg modules), the first step was to get the 2 views system and help in place and then patch the rest. This is not the final, production ready code, even the menu logic (js) is not yet updated, so please bear with us as we’ll try to finish this task |
|
It would be really good if only production-ready code would be commited to this repository... It doesn't look like this PR was ready to be merged. |
No idea what it means but I will be patient. |
|
@Hackwar I think due to lack of people working on the other repo the decision was to move the code here so more devs can contribute and thus accelerate the process. The j4 menu is known to been far from production ready code since the first alpha, nothing new here |
|
@infograf768 looks like this:
Source: https://projects.invisionapp.com/share/8SES9JLZB#/screens/267320995 |
|
Link to the article: https://magazine.joomla.org/issues/issue-nov-2017/item/3289-episode-iv-a-new-user-interface-for-the-joomla-backend Link to the prototype (Mentioned in the article): https://projects.invisionapp.com/share/8SES9JLZB#/screens/266861164_Desktop_-_Login |
|
@dgrammatiko I don't want to complain to much, because I've been guilty of this in the past, too, but I still want us to be able to release at any time with this repo. Merging unfinished code prevents that. From a quick glance, this is in the state of work-in-progress and thus not even in alpha state. Don't get me wrong, I value the work that is being done here, but I'd rather have this split up into X PRs which are only merged when ready. Even if it looks a bit strange from time to time because new code doesn't really fit visually with old code, at least everything would work... |
for reasons (that i don't agree with) it was decided that this was not to be the case at this stage of J4 development |
|
|
good that we have renamed the main branch to staging :-P |
|
I've said since JAB that I'm also starting to tighten up on the stuff I'm merging as I understand the repo now needs to move towards stability. Getting the new template design in was the one last missing part. Given the existing template was also broken in many ways I'd rather stop getting PRs to fix something that is broken and getting replaced and put in something that is nearly as PR for the missing module menu item: #21032 |
So how the heck an I'm confused 🤷♂️ |
If you look at our staging (J3) branch, it is basically production ready even when not tagged at all. "Alpha" doesn't mean it is broken (it may of course but doesn't have to). It means that the API may still change. "Beta" also doesn't mean it is broken, but it is "Feature Complete" and we don't expect any API changes anymore. RCs are then when we don't expect any changes anymore to the stable release except when we detect some new bugs, languages are usually also frozen at this point. |
|
4.0-dev is a development branch so the rule doesn't apply, our staging branch should be always in a state that we can make a release in a short time frame. If we have a 4.0-staging branch, then the rule will apply. |
|
@wilsonge this is a rater imported PR to be added to the 4.0 milestone :P Just for the record i have also added the new feature label. |
ghost
mentioned this pull request
This is the main body of work on the redesigned backend template per @svom and @coolcat-creations awesome new design in the Joomla Magazine from November.
https://magazine.joomla.org/issues/issue-nov-2017/item/3289-episode-iv-a-new-user-interface-for-the-joomla-backend
Clearly this isn't finished but should be as useable as the current one (so yes that means it's missing mobile design, it's missing RTL etc)
This is a PR so that some basic sanity testing can happen before it is merged and so the system tests can be fixed
TODO BEFORE MERGING