Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

com_categories: batch copy not copy permission #24730

Merged
merged 4 commits into from May 18, 2019

Conversation

Projects
None yet
8 participants
@alikon
Copy link
Contributor

commented Apr 26, 2019

Pull Request for Issue #8600.

Summary of Changes

let's copy permission too

Testing Instructions

  • Create a category.
  • Go to its permission tab and make a change. (e.g registered->allow creating)
  • Go to Batch and Copy it somewhere else.

Expected result

the permission are copyed

Actual result

permission are not copied

@franz-wohlkoenig

This comment has been minimized.

Copy link
Member

commented Apr 26, 2019

@peteruoi @AlexRed can you please test?

@brianteeman

This comment has been minimized.

Copy link
Contributor

commented Apr 26, 2019

Does this not have to be done everywhere there is function batchCopy

@alikon

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2019

yes, true, just let see if this is considered a bug fix or a new feature before
and then we can do other's pr for article etc....

@franz-wohlkoenig franz-wohlkoenig changed the title [com_categories] batch copy not copy permission com_categories: batch copy not copy permission Apr 27, 2019

@infograf768

This comment has been minimized.

Copy link
Member

commented Apr 27, 2019

I have tested this item successfully on 3947e0e

++


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24730.

@infograf768

This comment has been minimized.

Copy link
Member

commented Apr 27, 2019

Imho, looks rather as a bug fix, not a new feature.
Why copy a category instead of creating a new one if the permissions are not also copied?

@richard67

This comment has been minimized.

Copy link
Contributor

commented Apr 27, 2019

@infograf768 Well, you still can use copy because being too lazy to type again other stuff like title or desciption, which may be the same for some sub-categories below different parent categories.

So I am not sure if this PR has to be considered as bug fix or as a new feature.

I would vote for bug fix, too, but I think release leaders should decide.

=> Ping @HLeithner for 3.9 and @wilsonge for 4.0.

(Meanwhile I am preparing myself for testing.)

@infograf768

This comment has been minimized.

Copy link
Member

commented Apr 27, 2019

@alikon
we do have a Notice though:

[27-Apr-2019 11:40:38 Europe/Berlin] PHP Notice: Trying to get property of non-object in ~/libraries/src/UCM/UCMType.php on line 169

EDIT

The Notice is also present here before this PR

@alikon

This comment has been minimized.

Copy link
Contributor Author

commented Apr 27, 2019

@infograf768 unable to reproduce the notice
btw i've made #24736 for copying items to another category

@infograf768

This comment has been minimized.

Copy link
Member

commented Apr 27, 2019

hmm... Maybe the Notice is specific to a multilingual site?
That test site is regularly updated here, so it may be another aspect

@richard67

This comment has been minimized.

Copy link
Contributor

commented Apr 27, 2019

I have tested this item successfully on 3947e0e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24730.

@richard67

This comment has been minimized.

Copy link
Contributor

commented Apr 27, 2019

@infograf768 I was also not able to reproduce the notice. Tested on monolingual fresh install with testing sample data.

@infograf768

This comment has been minimized.

Copy link
Member

commented Apr 27, 2019

Ok, found the issue. I had in the content_types table a remaining of a 3rd party extension (Breezing forms) which had been deleted for long from the site but left a row in the table...

@infograf768 infograf768 removed the PR-staging label Apr 27, 2019

@infograf768

This comment has been minimized.

Copy link
Member

commented Apr 27, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24730.

@joomla-cms-bot joomla-cms-bot added the RTC label Apr 27, 2019

@richard67 richard67 referenced this pull request Apr 27, 2019

Closed

Semver j3 #24728

@richard67

This comment has been minimized.

Copy link
Contributor

commented May 18, 2019

@franz-wohlkoenig Any reason why this is not merged? Has 2 good tests, has RTC. Only thing is it needs a "rebase" (i.e. merge from staging).

@infograf768

This comment has been minimized.

Copy link
Member

commented May 18, 2019

Rebased.
@HLeithner to decide merging or not.

@HLeithner HLeithner merged commit 91d6dba into joomla:staging May 18, 2019

4 checks passed

Hound No violations found. Woof!
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr Build is passing
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@HLeithner

This comment has been minimized.

Copy link
Member

commented May 18, 2019

thx

@joomla-cms-bot joomla-cms-bot removed the RTC label May 18, 2019

@HLeithner HLeithner added this to the Joomla 3.9.7 milestone May 18, 2019

@alikon alikon deleted the alikon:patch-81 branch May 19, 2019

tecpromotion added a commit to tecpromotion/joomla-cms that referenced this pull request May 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.