com_categories: batch copy not copy permission

[alikon]

Pull Request for Issue #8600.

Summary of Changes

let's copy permission too

Testing Instructions

• Create a category.
• Go to its permission tab and make a change. (e.g registered->allow creating)
• Go to Batch and Copy it somewhere else.

Expected result

the permission are copyed

Actual result

permission are not copied

[ghost]

@peteruoi @AlexRed can you please test?

[brianteeman]

Does this not have to be done everywhere there is function batchCopy

[alikon]

yes, true, just let see if this is considered a bug fix or a new feature before
and then we can do other's pr for article etc....

[infograf768]

I have tested this item ✅ successfully on 3947e0e

++

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24730.}

[infograf768]

Imho, looks rather as a bug fix, not a new feature.
Why copy a category instead of creating a new one if the permissions are not also copied?

[richard67]

@infograf768 Well, you still can use copy because being too lazy to type again other stuff like title or desciption, which may be the same for some sub-categories below different parent categories.

So I am not sure if this PR has to be considered as bug fix or as a new feature.

I would vote for bug fix, too, but I think release leaders should decide.

=> Ping @HLeithner for 3.9 and @wilsonge for 4.0.

(Meanwhile I am preparing myself for testing.)

[infograf768]

@alikon
we do have a Notice though:

[27-Apr-2019 11:40:38 Europe/Berlin] PHP Notice: Trying to get property of non-object in ~/libraries/src/UCM/UCMType.php on line 169

EDIT

The Notice is also present here before this PR

[alikon]

@infograf768 unable to reproduce the notice
btw i've made #24736 for copying items to another category

[infograf768]

hmm... Maybe the Notice is specific to a multilingual site?
That test site is regularly updated here, so it may be another aspect

[richard67]

I have tested this item ✅ successfully on 3947e0e

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24730.}

[richard67]

@infograf768 I was also not able to reproduce the notice. Tested on monolingual fresh install with testing sample data.

[infograf768]

Ok, found the issue. I had in the content_types table a remaining of a 3rd party extension (Breezing forms) which had been deleted for long from the site but left a row in the table...

[infograf768]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24730.}

[richard67]

@franz-wohlkoenig Any reason why this is not merged? Has 2 good tests, has RTC. Only thing is it needs a "rebase" (i.e. merge from staging).

[infograf768]

Rebased.
@HLeithner to decide merging or not.

[HLeithner]

thx