Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.0.] Remove obsolete and outdated trigger #24941

Merged
merged 3 commits into from
May 19, 2019
Merged

[4.0.] Remove obsolete and outdated trigger #24941

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f2d08b1
Remove obsolete and outdated trigger
roland-d May 18, 2019
485f985
Use the correct trigger
roland-d May 18, 2019
ea2ea83
Merge branch '4.0-dev' into feature/remove-obsolete-trigger
infograf768 May 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions libraries/src/Table/Table.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1320,9 +1320,6 @@ public function checkIn($pk = null)
);
$this->getDispatcher()->dispatch('onTableAfterCheckin', $event);

$dispatcher = \JEventDispatcher::getInstance();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think it is correct, in this way you don't track anymore the onAfterCheckin event
should be coverted in j4 style

Factory::getApplication()->triggerEvent('onAfterCheckin', array($this->_tbl));

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that works, too, I've just tested. Error also disappears when replacing lines 1323 and 1324 in the unpatched file by the line which @alikon suggests. So I think he is right.

Copy link
Contributor

@alikon alikon May 18, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe the confusion arise cause there are 2 event :

  1. onAfterCheckin used by actionlog
  2. onTableAfterCheckin unused by core

$dispatcher->trigger('onAfterCheckin', array($this->_tbl));

return true;
}

Expand Down