Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update joomla/string from framework to fix Appveyor #25243

Merged

Conversation

richard67
Copy link
Member

@richard67 richard67 commented Jun 16, 2019

Pull Request for Issue #25234 .

Summary of Changes

Update joomla/string package from framework.

Testing Instructions

See #25234 (comment) .

Expected result

String package up to date.

Appveyor does not fail for the reason described below for actual result.

Actual result

String package not up to date.

Appveyor tests failed here:
https://github.com/joomla/joomla-cms/blob/staging/libraries/vendor/joomla/string/src/phputf8/utf8.php#L38
with error

Warning: A non-numeric value encountered in C:\projects\joomla-cms\libraries\vendor\joomla\string\src\phputf8\utf8.php on line 38

Documentation Changes Required

None.

@richard67 richard67 changed the title WIP Staging composer update joomla string WIP Update joomla/string from framework to fix Appveyor Jun 16, 2019
@richard67 richard67 mentioned this pull request Jun 16, 2019
@richard67 richard67 marked this pull request as ready for review June 16, 2019 21:24
@richard67 richard67 changed the title WIP Update joomla/string from framework to fix Appveyor Update joomla/string from framework to fix Appveyor Jun 16, 2019
@HLeithner HLeithner merged commit 93cb1ad into joomla:staging Jun 16, 2019
@HLeithner
Copy link
Member

thx

@HLeithner HLeithner added this to the Joomla 3.9.9 milestone Jun 16, 2019
@richard67 richard67 deleted the staging-composer-update-joomla-string branch June 16, 2019 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants