New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] add fields items to contact menu #26540
Conversation
|
we need to deeply review how we provide updates ---- if we are talking about sql |
That's why I asked someone else to do it :) |
Hmm, thinking more about it: If it is really ok in 3.9 and not ok in 4.0, maybe there is already some 4.0.0-*.sql update script which removes those menu items? If this is the case, then this update script has to be changed. I can check that on weekend, but tonight and tomorrow night I won't have time. |
Well, I just checked: Seems there is no 4.0 update sql deleting those menu items, so everything should be ok, no update sql needed. |
let me clarify... |
Correct. |
you cannot guess what are the different lft,rgt values for all installation--- so |
but shouldn't the "rebuild" button do that after an update? |
are you talking about menus table only ? |
Well I did not wanna speak against it, I only asked for my better understanding. |
i hope i've at least instilled some grams of curiosity 😃 |
its also why I would not have had any 4.0sql update files at all and just done them all at once when we get to beta. just creates a lot of useless files that will be deleted |
Add a separator between |
after a more proof review of 3.x we still need an update sql .... i was wrong |
Postgres System Test is failing: |
@SniperSister @alikon and me know about this. I've made a PR to his branch to fix it, he will merge as soon as lunch finished, I think. |
Fix postgresql/joomla.sql
@SniperSister Tests are passing here now. |
I have tested this item ✅ successfully on 661f93b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26540. |
@brianteeman Could you test this, too? I've helped with updating testing instructions and making a zip package for an update test because Nicola is a bit busy with preparing for JoomlaDay Italy, so see the updated instructions for details. |
Co-Authored-By: Quy <quy@fluxbb.org>
@infograf768 The first message about template not available is normal after the update but should disappear and not come again after having liogged in to backend for the first time and then having navigated 1 time withint the backend. The 2nd message should be fixed when my database null date works will be finished. It normally does not appear on a pre 8.0 MySQL with normal configuration regarding session parameters and server variables, e.g. for strict mode. Did you test this on MySQL 8? The SQL error and empty dashboards ... maybe I've made a mistake when packing the update zip package which is linked in the testing instructions for test 2? I have to check that tonight after work (German time). |
Nope. |
I have tested this item 🔴 unsuccessfully on 4f755bc This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26540. |
@nadjak77 Wrong order of processing. It has to be
You have done the new installation and then applied the patch but then have not done new installation again, so your database did not include the changes here. |
I've just updated the update package for Test 2 to latest nightly build of today. Testers please follow exactly the testing instructions given in the description of this PR. |
@nadjak77 Please change back your testing result to "not tested" in the issue tracker. The test failed because you did not follow exactly the testing instructions. And if you have enough time, please test again in the right way, that would be very appreciated. Anyway thanks for testing, even if wrong now, because we need volunteers who help with testing. |
I have tested this item ✅ successfully on 4f755bc This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26540. |
I have tested this item ✅ successfully on 4f755bc This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26540. |
1 similar comment
I have tested this item ✅ successfully on 4f755bc This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26540. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26540. |
Thanks! |
Thank you for making the custom fields usable again. |
imo is matter of personal taste / consistency |
Pull Request for replace of #23366 .
Summary of Changes
Add menu items for fields and field groups below the "Contact" menu item in the admin menu.
On update, use script.php to add these new menu items so that lft and rgt are set correctly in the (nested) menu table.
Testing Instructions
If you have both MySQL and PostgreSQL, please test on both if possible.
Test 1: New installation
configuration.php
and delete all Joomla database tables in PhpMyAdmin or PhpPgAdmin (depending on your database type).Result: See section "Expected result" below.
Test 2: Update
Result: See section "Expected result" below.
Expected result
you have:
below Contact menu item
Actual result
You don't have these 2 menu items below Contact component
Additional comments
We need to review how we deal with changes of content in nested tables when updating because issues with that are is quite hard to fix with update sql scripts. (personal consideration)