[5.0] Remove obsolete contact and finder menu items creation from postflight method in script.php #40280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
thanks |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
This pull request (PR) removes the methods "contactItems" and "finderItems" and their usage in the "postflight" method from file "administrator/components/com_admin/script.php".
The removed methods and the removed code in the "postflight" method once had been added with version 4.0.0 with PR #26540 and then had been modified and extended with PR #27032 for adding missing admin menu items of com_contact and com_finder when updating from 3.10 to 4.x.
The PR is one in a sequence of PR's for removing obsolete actions from script.php which are not relevant anymore because updates to 5.x will have to be done from a 4.4 version, like it is now with 4.x from 3.10.
When this PR here and PR #40281 have been merged, the "postflight" method will not do anything anymore.
I will make a follow up PR when that has happened to change the version number in the
version_comparecall from4.0.0to5.0.0here https://github.com/richard67/joomla-cms/blob/5.0-dev/administrator/components/com_admin/script.php#L885-L887 and below that add a comment like// Add here code which shall only be performed when updating from 4.4 to 5.xor so.The "postflight" method should be kept for such future use, I think.
Other opinions are welcome.
Testing Instructions
Code review: Make sure that the removed methods are not called anywhere else and that they do something which is definitely not needed when updating from 4.4 to 5.
Optional real test: Make sure that updating the latest 4.4-dev nightly build to the update package created by drone works when using the upload & update method.
Actual result BEFORE applying this Pull Request
Obsolete code for adding admin menu items of com_contact and com_finder when updating from 3.10 to 4.x is present in script.php.
Expected result AFTER applying this Pull Request
Obsolete code for adding admin menu items of com_contact and com_finder when updating from 3.10 to 4.x is not present anymore in script.php.
Updating from a 4.4-dev nightly build works.
Link to documentations
Please select:
No documentation changes for docs.joomla.org needed
No documentation changes for manual.joomla.org needed