Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#27744 allow showing ucm_content items with core_access=0. Similar fi… #27745

Merged
merged 2 commits into from
Feb 6, 2020
Merged

#27744 allow showing ucm_content items with core_access=0. Similar fi… #27745

merged 2 commits into from
Feb 6, 2020

Conversation

svenbluege
Copy link
Contributor

…x for the similar tags module: 0416160

Pull Request for Issue #27744

Summary of Changes

Allow displaying items with core_access=0 from _ucm_content in the Popular Tags module. The zero value is the result if a component does not use an access column.

Testing Instructions

  • create the popular tags module
  • create an article
  • create a content tag
  • assign that tag to the article
  • change the core_access value for the article representation in _ucm_content to 0

Expected result

I see my tag in the popular tags module.

Actual result

I don't see my tag in the popular tags module.

Documentation Changes Required

No.

modules/mod_tags_popular/helper.php Outdated Show resolved Hide resolved
@richard67
Copy link
Member

Will test later today.

@richard67
Copy link
Member

I have tested this item ✅ successfully on 99ce3c3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27745.

@chmst
Copy link
Contributor

chmst commented Feb 2, 2020

I have tested this item ✅ successfully on 99ce3c3

The PR works as described, therefore the test is successful.
But a question: When is core_access set to 0?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27745.

@richard67
Copy link
Member

@chmst Is explained in the issue #27744 . There may be 3rd party components using an own acl handling and not the core one. We already have the same change as done here in the similar tags module, was once made by @Bakual . So it is ok.

@SharkyKZ
Copy link
Contributor

SharkyKZ commented Feb 5, 2020

RTC.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27745.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 5, 2020
@rdeutz rdeutz merged commit fe798dd into joomla:staging Feb 6, 2020
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 6, 2020
@rdeutz rdeutz added this to the Joomla! 3.9.16 milestone Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants