Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new "sponsored" and "ugc" options to rel attribute for external links #28055

Merged
merged 2 commits into from
Feb 24, 2020
Merged

Add new "sponsored" and "ugc" options to rel attribute for external links #28055

merged 2 commits into from
Feb 24, 2020

Conversation

simbus82
Copy link
Contributor

Pull Request for issue #26312

Why

https://support.google.com/webmasters/answer/96569?hl=en
Advanced users (copywriters, bloggers, etc.) are very concerned about SEO.
Their projects often live thanks to affiliation, sponsorship and advertising.
It is important to provide them with all the tools necessary for a correct supply of information to the search engine, so as not to be penalized and to constantly improve aspects such as indexing and positioning.
These two options specifically help Google identify the behavior of outbound links from Joomla sites, thus providing correct information on what to expect from the connected external source.

Summary of Changes

Add new "sponsored" and "ugc" options to rel attribute of external URL menu type.

Testing Instructions

Add new menu item
Select System Links > URL
Click Link Type tab
Click Link Rel Attribute dropdown
See spondored and ugc option

Next Step (not in this PR)

Users should select more than one option for "rel" attribute.
https://www.w3.org/TR/html401/struct/links.html#adef-rel

rel = link-types [CI]
This attribute describes the relationship from the current document to the anchor specified by the href attribute.
The value of this attribute is a space-separated list of link types.

…inks

Pull Request for #26312

###Why
https://support.google.com/webmasters/answer/96569?hl=en
Advanced users (copywriters, bloggers, etc.) are very concerned about SEO.
Their projects often live thanks to affiliation, sponsorship and advertising.
It is important to provide them with all the tools necessary for a correct supply of information to the search engine, so as not to be penalized and to constantly improve aspects such as indexing and positioning.
These two options specifically help Google identify the behavior of outbound links from Joomla sites, thus providing correct information on what to expect from the connected external source.

### Summary of Changes
Add new "sponsored" and "ugc" options to rel attribute of external URL menu type.

### Testing Instructions
Add new menu item
Select System Links > URL
Click **Link Type** tab
Click **Link Rel Attribute** dropdown
See **spondored** and **ugc** option

### Next Step (not in this PR)
Users should select more than one option for "rel" attribute.
https://www.w3.org/TR/html401/struct/links.html#adef-rel
> rel = link-types [CI]
> This attribute describes the relationship from the current document to the anchor specified by the href attribute.
> The value of this attribute is a space-separated list of link types.
@@ -35,6 +35,8 @@
<option value="nofollow"/>
<option value="noopener"/>
<option value="noreferrer"/>
<option value="sponsored"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest are sorted alphabetically.

@brianteeman
Copy link
Contributor

Please add them in alphabetical order and not just randomly insert in the middle

@simbus82
Copy link
Contributor Author

Sorry, i added the options with a "logical" positioning (not randomly): now are alphabetically ordered.
Thanks!

@simbus82
Copy link
Contributor Author

I have tested this item ✅ successfully on 9246379

Tested successfully with Joomla 3.9.15, works well in Isis Backend.

Tested successfully (if the rel is present) in frontend with beez3, protostar and a custom template.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28055.

@brianteeman
Copy link
Contributor

@simbus82 For obvious reasons we dont mark successful tests on our own code. Obviously it is already assumed that you tested your code when you submitted it

@richard67
Copy link
Member

@simbus82 Altered your test result to "not tested" in the issue tracker due to reason @brianteeman explained above.

@Quy
Copy link
Contributor

Quy commented Feb 24, 2020

I have tested this item ✅ successfully on 9246379


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28055.

1 similar comment
@jwaisner
Copy link
Member

I have tested this item ✅ successfully on 9246379


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28055.

@jwaisner
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28055.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 24, 2020
@zero-24 zero-24 added this to the Joomla! 3.9.16 milestone Feb 24, 2020
@zero-24
Copy link
Contributor

zero-24 commented Feb 24, 2020

Merging thanks 👍 And thanks @simbus82 for your first contribution to the Joomla Core.

@zero-24 zero-24 merged commit e74a2c9 into joomla:staging Feb 24, 2020
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants