Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transparency lost when cropping/resizing images #30977

Merged
merged 2 commits into from Oct 11, 2020
Merged

Transparency lost when cropping/resizing images #30977

merged 2 commits into from Oct 11, 2020

Conversation

SharkyKZ
Copy link
Contributor

@SharkyKZ SharkyKZ commented Oct 7, 2020

Closes #30975.

Summary of Changes

Fixes transparency being lost when cropping/resizing PNG images.

Testing Instructions

Go to edit template files in backend.
Select one of PNG images in images directory.
Use Crop and Resize buttons to crop/resize the image.

Note, because template is styled to have a black background behind transparent images, you'll have to inspect image files directly on your server or in the browser.

Actual result BEFORE applying this Pull Request

Transparency is lost, images get a black background.

Expected result AFTER applying this Pull Request

Images maintain transparency.

Documentation Changes Required

No.

@Quy
Copy link
Contributor

Quy commented Oct 9, 2020

I have tested this item ✅ successfully on df6c803


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30977.

1 similar comment
@ghost
Copy link

ghost commented Oct 10, 2020

I have tested this item ✅ successfully on df6c803


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30977.

@alikon
Copy link
Contributor

alikon commented Oct 10, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30977.

@joomla-cms-bot joomla-cms-bot added RTC This Pull Request is Ready To Commit and removed PR-staging labels Oct 10, 2020
@HLeithner
Copy link
Member

Don't we support other types like webp?

@SharkyKZ
Copy link
Contributor Author

No.

@HLeithner HLeithner merged commit 09b46f7 into joomla:staging Oct 11, 2020
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 11, 2020
@HLeithner
Copy link
Member

Thanks

@SharkyKZ SharkyKZ deleted the j3/fix/template-image-transparency branch October 11, 2020 12:04
@zero-24 zero-24 added this to the Joomla! 3.9.23 milestone Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[4][Media Manager] Transparency is not preserved when cropping image
7 participants