Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Frontend List articles in a category: adding Clear filter, refactoring layout for a11y+ #30981

Merged
merged 1 commit into from
Oct 8, 2020

Conversation

infograf768
Copy link
Member

Summary of Changes

Adds Clear filter.
Takes off Filter button when search field is set to Tags or Month.
Takes off unecessary fieldset and title
a11y all that needs to
Separates List Limit from Filters group and display to the right. (Same as #30868)
Moves badges and flags below article title.

Testing Instructions

Create some articles.
Create a Category List menu item.
Set some parameters, including various types of Filter Field
Display in frontend. Test filter, clear.

Modify parameters to test all possibilities.

Patch. RUN NPM CI in order to use the Clear button.
test again

Actual result BEFORE applying this Pull Request

Screen Shot 2020-10-07 at 10 43 54

Screen Shot 2020-10-07 at 10 42 11

Screen Shot 2020-10-07 at 10 40 26

Expected result AFTER applying this Pull Request

Screen Shot 2020-10-07 at 10 34 03

Screen Shot 2020-10-07 at 10 37 48

Screen Shot 2020-10-07 at 10 37 58

Screen Shot 2020-10-07 at 10 46 17

Screen Shot 2020-10-07 at 10 39 13

Documentation Changes Required

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Oct 7, 2020
@drmenzelit
Copy link
Contributor

I have tested this item ✅ successfully on e4ad615

Tested on Joomla 4 Beta 5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30981.

@paternax
Copy link

paternax commented Oct 7, 2020

I have tested this item ✅ successfully on e4ad615

4.0.0-beta5-dev


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30981.

@Quy Quy removed NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Oct 7, 2020
@Quy
Copy link
Contributor

Quy commented Oct 7, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30981.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 7, 2020
@Quy Quy added the PR-4.0-dev label Oct 7, 2020
@rdeutz rdeutz added this to the Joomla 4.0 milestone Oct 8, 2020
@rdeutz rdeutz merged commit d63db91 into joomla:4.0-dev Oct 8, 2020
@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester and removed RTC This Pull Request is Ready To Commit labels Oct 8, 2020
@infograf768 infograf768 deleted the 4.0_articles_list branch October 8, 2020 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants