[4.0] Normalise Featured Contact List

[infograf768]

Summary of Changes

Follow up on #30813 and #30859
Warning: these 2 PR have to be present in your test site to test the Clear button.

npm ci has to be applied

Changes:
Normalises the table display
Adds a Title Search Filter, Filter and Clear buttons.
a11y legend and scope added
Modified the search placeholder (it is also used in Contact List but I forgot to modify it there)
Used Title instead of Name for column heading, as in Contact list

Testing Instructions

Create some contacts and set them to featured.
Create a Featured Contacts menu item.
Display in frontend.

After patch, test that the Filter and the Clear button work as should

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

NOTE

No idea why we display the NUM in the first column.
If nobody knows why, we can get rid of it.

Meaanwhile, I kept in the code

					<tr class="<?php echo ($i % 2) ? 'odd' : 'even'; ?>" itemscope itemtype="https://schema.org/Person">
						<td class="item-num">
							<?php echo $i; ?>
						</td>

[chmst]

I'd like to get rid of the Number!

[infograf768]

I'd like to get rid of the Number!

Me too, if it is BC.

[brianteeman]

There is no b/c issue

[chmst]

Tested with success. If you remove the number column, I'll re-test.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30868.}

[infograf768]

There is no b/c issue

@brianteeman
Do you mean I can get rid of that column?

Any idea about this very specific <tr>
<tr class="<?php echo ($i % 2) ? 'odd' : 'even'; ?>" itemscope itemtype="https://schema.org/Person">

Should I replace it with the same stuff we have in the category list?

						<?php if ($this->items[$i]->published == 0) : ?>
							<tr class="system-unpublished featured-list-row<?php echo $i % 2; ?>">
						<?php else : ?>
							<tr class="featured-list-row<?php echo $i % 2; ?>" >
						<?php endif; ?>

[brianteeman]

1. yes - its just a display you are not removing data

2. that css is/was to create "stripes"

[infograf768]

@chmst @brianteeman
please test again
also moved Unpublished badge below contact title (log to see)

[chmst]

Filter and list limit are not a fieldset. They are not related to each other.

[infograf768]

Please look at similar code for
components/com_content/tmpl/category/default_articles.php

[chmst]

no need for a legend

[infograf768]

fieldset needs a legend (and wave asks for it): see

joomla-cms/components/com_content/tmpl/category/default_articles.php

Lines 69 to 70 in 06fe4d2

	<fieldset class="com-content-category__filters filters btn-toolbar clearfix">
	<legend class="sr-only"><?php echo Text::_('COM_CONTENT_FORM_FILTER_LEGEND'); ?></legend>

joomla-cms/components/com_contact/tmpl/category/default_items.php

Lines 35 to 36 in 06fe4d2

	<fieldset class="com-contact-category__filters filters btn-toolbar">
	<legend class="sr-only"><?php echo Text::_('COM_CONTACT_FORM_FILTER_LEGEND'); ?></legend>

[chmst]

The list is a big improvement.

For the filter, I have some doubts.

• The form is only the filter, not the whole list
• Search field and list limit are no fieldset, they don't belong together
• The clear button does not clear the input.

[infograf768]

The clear button works if

Follow up on #30813 and #30859
Warning: these 2 PR have to be present in your test site to test the Clear button.

npm ci has to be applied

[infograf768]

@chmst
I replied to your concerns above, I guess.

[brianteeman]

The point was that it's not a fiedset

…

On Sat, 3 Oct 2020, 15:44 infograf768, ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In components/com_contact/tmpl/featured/default_items.php <#30868 (comment)>: > <form action="<?php echo htmlspecialchars(Uri::getInstance()->toString()); ?>" method="post" name="adminForm" id="adminForm"> + <?php if ($this->params->get('filter_field') || $this->params->get('show_pagination_limit')) : ?> <fieldset class="com-contact-featured__filters filters"> Please look at similar code for components/com_content/tmpl/category/default_articles.php — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#30868 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJ4P4OKGAWNTD2WLT4DYN3SI42DRANCNFSM4SBRDOUQ> .

[infograf768]

The point was that it's not a fiedset

Then you may have to change the code for articles in 3.x and for articles and contacts lists in 4.0-dev, which you tested OK

https://github.com/joomla/joomla-cms/blob/staging/components/com_content/views/category/tmpl/default_articles.php#L67-L104

[brianteeman]

I have no opinion on if it should be a fieldset or not. I was merely explaining why @chmst said that you should not have the legend.

[infograf768]

Animated gif concerning the Clear filter.

[infograf768]

I obviously can take off the part concerning fieldset, here and in List Contacts in a Category, if desired.

[infograf768]

I am asking @zwiastunsw to please help on this decision as we have only one input (the searchfield)
One aspect is sure: if we keep the fieldset, it must have a legend.

[infograf768]

After discussing with @chmst and @zwiastunsw fieldset is not necessary.
Reworked the tmpl.

Please test.

Note

Another PR will follow for contacts list and articles list.

[chmst]

I have tested this item ✅ successfully on 510dc5f

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30868.}

[richard67]

I have tested this item ✅ successfully on 510dc5f

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30868.}

[richard67]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30868.}

[infograf768]

title removed as requested.
I guess no need to test again.

[HLeithner]

Thanks

[infograf768]

Similar PR for articles
#30981