Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Frontend: Normalise List contacts #30984

Merged
merged 1 commit into from
Oct 8, 2020

Conversation

infograf768
Copy link
Member

Summary of Changes

As was done in
#30868 (merged)
and #30981
this PR takes off the fieldset and the input title

Display difference: Limit box will now display to the right.

Testing Instructions

Create multiple contacts in the same category.
Create a List Contacts in a Category menu item for this category.
Make sure Filter Field is set to Show in the menu parameters.
Display the menu item in frontend.

Actual result BEFORE applying this Pull Request

Screen Shot 2020-10-07 at 18 15 45

Expected result AFTER applying this Pull Request

Screen Shot 2020-10-07 at 18 13 36

@chmst
Copy link
Contributor

chmst commented Oct 7, 2020

I have tested this item ✅ successfully on c5587b0

On code inspect, it is a known construction.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30984.

@jwaisner
Copy link
Member

jwaisner commented Oct 7, 2020

I have tested this item ✅ successfully on c5587b0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30984.

@jwaisner
Copy link
Member

jwaisner commented Oct 7, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30984.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 7, 2020
@Quy Quy added the PR-4.0-dev label Oct 7, 2020
@rdeutz rdeutz added this to the Joomla 4.0 milestone Oct 8, 2020
@rdeutz rdeutz merged commit a205d22 into joomla:4.0-dev Oct 8, 2020
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 8, 2020
@infograf768 infograf768 deleted the 4.0_normalise_contacts_list branch October 8, 2020 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants