Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] re-do temporary change of filter published-condition #31155

Merged
merged 3 commits into from
Nov 14, 2020

Conversation

chmst
Copy link
Contributor

@chmst chmst commented Oct 19, 2020

Summary of Changes

As required in #30467 the filter.condition is changed to filter.published.

Testing Instructions

As in #30445
In a module "Articles latest" only published items my be displayed.

Documentation Changes Required

no

@richard67 richard67 changed the title [4.0] re-do temporary change of filer published-condition [4.0] re-do temporary change of filter published-condition Oct 19, 2020
@Quy Quy added the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Oct 24, 2020
@maikol-ortigueira
Copy link

I can not replicate this.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31155.

@Quy Quy removed the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Oct 29, 2020
@particthistle
Copy link
Member

I have tested this item ✅ successfully on f97121c

Tested successfully. Thanks @chmst.

The code is a refactoring of the filter selector, so no change to what appears is expected for the test case. Tried various ordering options for the module, all were successful.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31155.

@alikon
Copy link
Contributor

alikon commented Nov 1, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31155.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 1, 2020
@richard67
Copy link
Member

@alikon RTC with only 1 test? Or have you tested, too, and just forgotten to submit the test result?

@alikon
Copy link
Contributor

alikon commented Nov 9, 2020

I have tested this item ✅ successfully on 9702057


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31155.

@Quy
Copy link
Contributor

Quy commented Nov 9, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31155.

@Quy Quy removed RTC This Pull Request is Ready To Commit hacktoberfest-accepted labels Nov 9, 2020
@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 9, 2020
@richard67
Copy link
Member

Previous test by @particthistle was still valid because the commit after that test was just a clean branch update.

I've restored the test result in the issue tracker so it's correctly counted there and here.

@richard67 richard67 merged commit 9bfcbde into joomla:4.0-dev Nov 14, 2020
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 14, 2020
@richard67
Copy link
Member

Thanks!

@richard67 richard67 added this to the Joomla 4.0 milestone Nov 14, 2020
@chmst chmst deleted the modarticlehelper-revert-condition branch July 7, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants