-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Replace filter.condition by filter.published in com_content #30467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chmst
changed the title
Replace filter.condition by filter.published in com_content
[4.0] Replace filter.condition by filter.published in com_content
Aug 24, 2020
sandewt
reviewed
Aug 25, 2020
I have tested this item ✅ successfully on 01c7762 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30467. |
Remove?
See:
|
Quy
added
the
Updates Requested
Indicates that this pull request needs an update from the author and should not be tested.
label
Sep 10, 2020
I have tested this item ✅ successfully on 01c7762 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30467. |
alikon
removed
the
Updates Requested
Indicates that this pull request needs an update from the author and should not be tested.
label
Nov 9, 2020
richard67
pushed a commit
that referenced
this pull request
Nov 14, 2020
As required in #30467 the filter.condition is changed to filter.published.
Previous test results are still valid since last commit was only a clean branch update => RTC. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30467. |
Good to be merged .. I just gave it a test, too. |
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started here #30459 .
Summary of Changes
In com_content and related modules, filter.condition is used for filtering publishedm unpublished, archived, trashed data.
This might cause problems when 3rd party extension set filters for articles.
This PR sets back the name to filter.published in J3. It does not change the behavour in any way.
Testing Instructions
Testing is not as easy, as these filters are used in different ways. The test is successful, if nothing in Joomla frontend changes with the patch applied.
You should have some content i.e. testing sample data - categories and articles, some archived, some published, some unpublished and some trashed.
And you should have modules for every kind of articles.
Now check in the frontend: The modules must show only published articles. Your blogs should show only published articles.