Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Category ALT text #31326

Merged
merged 3 commits into from
Nov 14, 2020
Merged

[4.0] Category ALT text #31326

merged 3 commits into from
Nov 14, 2020

Conversation

brianteeman
Copy link
Contributor

@brianteeman brianteeman commented Nov 6, 2020

Continues the work of #31318 and #31323 by correcting the behaviour of the alt text and changing the strings to match the work done in #31318

Background

To read why this change is very important see #31318

Testing Part 1

Testing is really easy. No npm, js or css involved.
Merge the pull request and then create a content category and a contact category and add an image

image

Testing Part 2

Please test three scenarios when adding an image for a menu item of Content Category Blog, Content Category List, Contact Category

  1. Image Description (Alt Text) = Empty
    No Description = unchecked

  2. Image Description (Alt Text) = "some description"
    No Description = unchecked

  3. Image Description (Alt Text) = Empty
    No Description = checked

The expected behaviour for each of these tests is

1.<img src="filename.jpg">
2. <img src="filename.jpg" alt="some description">
3. <img src="filename.jpg" alt >
or <img src="filename.jpg" alt="">

PLEASE do not comment on what you think the code does but apply the PR and test it. Getting very tired of people blocking PR with their comments without actually testing the code.

cc @carcam

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.0-dev labels Nov 6, 2020
@infograf768
Copy link
Member

I have tested this item ✅ successfully on 206c859


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31326.

1 similar comment
@priyankaSahutekdi
Copy link

I have tested this item ✅ successfully on 206c859


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31326.

@alikon
Copy link
Contributor

alikon commented Nov 7, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31326.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 7, 2020
@ceford
Copy link
Contributor

ceford commented Nov 7, 2020

The **loading="lazy" ** is absent. Is that due to copy/paste instructions? Can you tell us under what conditions alt appears without =""?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31326.

@brianteeman
Copy link
Contributor Author

Fixed the copy/paste error

Can you tell us under what conditions alt appears without =""
Basically if it is alt="" then some browsers when you inspect instead of view source abbreviate alt="" to alt

@richard67 richard67 merged commit 079d11a into joomla:4.0-dev Nov 14, 2020
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 14, 2020
@richard67
Copy link
Member

Thanks!

@richard67 richard67 added this to the Joomla 4.0 milestone Nov 14, 2020
@brianteeman
Copy link
Contributor Author

thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants