Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHP CS errors introduced with PR 31672 #31878

Merged
merged 1 commit into from
Jan 12, 2021

Conversation

richard67
Copy link
Member

@richard67 richard67 commented Jan 7, 2021

Pull Request for Issue # .

Summary of Changes

Use tabs and not spaces for indentation in PHP files.

Testing Instructions

Code review + check that PHP CS succeeds in Drone tests.

Actual result BEFORE applying this Pull Request

Spaces used for indentation at the end of file layouts/joomla/form/field/password.php.

PHP CS fails in Drone tests.

Expected result AFTER applying this Pull Request

Tabs used for indentation at the end of file layouts/joomla/form/field/password.php.

PHP CS succeeds in Drone tests.

Documentation Changes Required

None.

@toivo
Copy link
Contributor

toivo commented Jan 7, 2021

I have tested this item ✅ successfully on e116a82

Tested successfully in 3.9.24-rc2 of 7 January.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31878.

@HLeithner HLeithner added this to the Joomla! 3.9.25 milestone Jan 7, 2021
@Quy
Copy link
Contributor

Quy commented Jan 7, 2021

I have tested this item ✅ successfully on e116a82


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31878.

@Quy Quy removed the PR-staging label Jan 7, 2021
@joomla-cms-bot joomla-cms-bot removed this from the Joomla! 3.9.25 milestone Jan 7, 2021
@Quy
Copy link
Contributor

Quy commented Jan 7, 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31878.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 7, 2021
@Quy Quy added the PR-staging label Jan 7, 2021
@HLeithner HLeithner merged commit d0b4022 into joomla:staging Jan 12, 2021
@HLeithner
Copy link
Member

thanks

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 12, 2021
@HLeithner HLeithner added this to the Joomla! 3.9.25 milestone Jan 12, 2021
@richard67 richard67 deleted the staging-fix-php-cs-2021-01-07 branch January 12, 2021 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants