Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix published attribute for Tag field #32332

Merged

Conversation

joomdonation
Copy link
Contributor

@joomdonation joomdonation commented Feb 6, 2021

Pull Request for Issue #32065 .

Summary of Changes

This simple PR fixes small issue with published attribute of Tag Field Type. According to our documentation, when published set to 1, only published tags should be displayed. As of right now, it always display both published and unpublished tags.

Testing Instructions

  1. Create some tags (some published tags and some unpublished tags)
  2. Modify this file https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_contact/models/forms/contact.xml#L235, add published="1" after that line.
  3. Create new contact:
  • Before patch: Both unpublished tags and published tags are being displayed
  • After patch: Only published tags are being displayed.

@richard67
Copy link
Member

@joomdonation As it's for staging and as far as I know we still have to support PHP 5.3 with Joomla 3.9.x and 3.10, it might be necessary to change the short array syntax [...] back to array(...).

@joomdonation
Copy link
Contributor Author

@richard67 You are right. It was changed automatically to short array syntax by my editor. I fixed it, should be fine now.

@joomdonation
Copy link
Contributor Author

Anyone knows why appveyor is not happy with change? Seems unrelated to the change in this PR.

@infograf768
Copy link
Member

Restarted appveyor

@toivo
Copy link
Contributor

toivo commented Feb 11, 2021

I have tested this item ✅ successfully on 12b2152

Tested successfully in 3.9.25-dev of 11 February in Wampserver 3.2.4 using PHP 8.0.1.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32332.

@richard67
Copy link
Member

I have tested this item ✅ successfully on 12b2152


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32332.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32332.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 11, 2021
@HLeithner HLeithner merged commit 1c4fa34 into joomla:staging Feb 23, 2021
@HLeithner
Copy link
Member

Thanks

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 23, 2021
@Quy Quy added this to the Joomla! 3.9.25 milestone Feb 23, 2021
@joomdonation joomdonation deleted the fix_published_attribute_for_tag branch February 24, 2021 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants