[4.0] fix webp support #33090
Closed
[4.0] fix webp support #33090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merged on review
* remove deprecated method * remove getCfg calls * Simplify code since every Joomla app has a get method Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
…r types on MySQL or MariaDB databases (joomla#32605) * Fix and simplify display width for MySQL change item * Fix type check for check query, too * Refactoring type check * Fix comments for regex's * Fix PHPCS 1st trial
merged on review, was already RTC as another PR
joomla#30991) * Menus do not comply with access levels set when logging-in through remember me feature
* Fix Privacy Request Email Data Export Error * Update administrator/components/com_privacy/views/request/view.html.php Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
* Add unit test for FilePathRule
… 3.9.25 release (joomla#32718) * Fix FilePathRule b/c issue * Exclude list cannot be empty now * Adapt new unit tests from PR 32723 to the changes of this one here * Add test cases for excluded core folders * Add exclude parameter to the form field for unit tests
…rade (joomla#31200) * Alternative presentation of compatibility checks for Joomla 4 from Joomla 3.10 * Alternative presentation of compatibility checks for Joomla 4 from Joomla 3.10 * remove accidental commit of .gitignore * Handle situation where we are running 3.10 with an extension what doesn't say its compatible with 3.10 - was incorrectly being reported as not supporting Joomla updater * Adding user guidance notes for update check * code style * Update administrator/components/com_joomlaupdate/controllers/update.php Co-authored-by: Quy <quy@fluxbb.org> * Update administrator/components/com_joomlaupdate/controllers/update.php Co-authored-by: Quy <quy@fluxbb.org> * Changed styling of compatibility feedback columns so that they are aligned Make warning message display be conditional on being relevant to the displayed output. * Revert accidentally committed file * Use tabs for HTML spacing Alphabetical language string key definition Resolve undeclared updateInfo['current'] * Missing ->state when checking "if ($currentCompatibilityStatus->state == 1)" * implement php cs changes * Changes suggested by zero-24 * change updating icon to Joomla ajax-loader.gif * Styling the results with margin left and right Also corrected language type Jomla instead of Joomla * Revert accidentally committed file * More changes suggested by zero-24 * Remove double spacing after full stop in language strings * Changes suggested by zero-24 'is not supported' - awaiting feedback on capitalisation * Changes suggested by zero-24 * js file spacing * Changes suggested by zero-24 * Hathor template override php layout * Changes suggested by zero-24 * Add link to Joomla updater instructions for developer's benefit * Revised version to reflect some of Brian's ideas * Revised layout in traffic light colour sequence, using 'More Detail' and chevrons to indicate more detail available link and including introductory explanation * Revised layout in traffic light colour sequence, using 'More Detail' and chevrons to indicate more detail available link and including introductory explanation * Revised layout in traffic light colour sequence, using 'More Detail' and chevrons to indicate more detail available link and including introductory explanation * Update administrator/language/en-GB/en-GB.com_joomlaupdate.ini Co-authored-by: Brian Teeman <brian@teeman.net> * Update media/com_joomlaupdate/js/default.js Co-authored-by: Quy <quy@fluxbb.org> * Update media/com_joomlaupdate/js/default.js Co-authored-by: Quy <quy@fluxbb.org> * Language string tweak as per bayareajenn's suggestion * First cut at flagging plugins that need attention * Add language string, confirm dialog and messages * should not have committed .gitignore * phpcs correction * Update administrator/components/com_joomlaupdate/models/default.php Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com> * Update administrator/components/com_joomlaupdate/models/default.php Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com> * Update administrator/language/en-GB/en-GB.com_joomlaupdate.ini Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com> * Update administrator/language/en-GB/en-GB.com_joomlaupdate.ini Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com> * Update administrator/components/com_joomlaupdate/views/default/tmpl/default_update.php Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com> * Update administrator/components/com_joomlaupdate/views/default/tmpl/default_update.php Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com> * Update administrator/components/com_joomlaupdate/views/default/tmpl/default_update.php Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com> * Update administrator/components/com_joomlaupdate/views/default/tmpl/default_update.php Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com> * zero-24 suggestions * Update administrator/language/en-GB/en-GB.com_joomlaupdate.ini Co-authored-by: Brian Teeman <brian@teeman.net> * Update administrator/language/en-GB/en-GB.com_joomlaupdate.ini Co-authored-by: Brian Teeman <brian@teeman.net> * Update administrator/language/en-GB/en-GB.com_joomlaupdate.ini Co-authored-by: Brian Teeman <brian@teeman.net> * Update administrator/language/en-GB/en-GB.com_joomlaupdate.ini Co-authored-by: Brian Teeman <brian@teeman.net> * Update administrator/language/en-GB/en-GB.com_joomlaupdate.ini Co-authored-by: Brian Teeman <brian@teeman.net> * Update administrator/language/en-GB/en-GB.com_joomlaupdate.ini Co-authored-by: Brian Teeman <brian@teeman.net> * Updates as suggested in Git Discussion to make potentially serious problem message clearer and to reduce prominence of php settings check adding in More Detail option * Updates as suggested in Git Discussion * Add problem plugin author and author URL information to the warning information Fix for javascript error thrown when no no live update is available Start update checker on DOMContentLoaded * phpcs * Fix for preupdatechecker not auto-starting automatically * Change language string COM_JOOMLAUPDATE_VIEW_DEFAULT_SHOW_MORE_COMPATIBILITY_INFORMATION to COM_JOOMLAUPDATE_VIEW_DEFAULT_EXTENSIONS_SHOW_MORE_COMPATIBILITY_INFORMATION so that it fits the relevant pattern of strings better Change "Currently Compatible Version" and "Update Compatible Version" to refer to current and target Joomla versions (@particthistle) Re-ordered columns -> "Extension Name, Extension Type, Installed Version, Joomla '3.x' Compatible Version, Joomla '4.x' Compatible Version" to make it easier to read and show progression of Joomla versions (@particthistle) Hide plugin warning and table headings as soon as all the plugins have been tested if they are all 'safe' on the 'live update' tab (@zero-24) * When there are no extensions installed or no non-Core Critical Plugins installed disable the wanrning messages and immediately exit the checking process. Co-authored-by: Geraint Edwards <jevents@gwesystems.com> Co-authored-by: Quy <quy@fluxbb.org> Co-authored-by: zero-24 <zero-24@users.noreply.github.com> Co-authored-by: Brian Teeman <brian@teeman.net> Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
joomla#31048 added support for webp images however it was not complete. MediaHelper::isImage was not updated to support webp. As a result while webp could be added to media manager as an allowed image format everything worked except for the display of the thumbnail. As this PR fixes that we might as well add webp to the default list of supported image formats. To test 1. either do a fresh install with the prebuilt package OR apply this pr, run npm ci and go to the media manager options. delete all the values in the Legal Extensions (File Types), Legal Image Extensions (File Types) and Legal MIME Types and then save the options. This will reset the value to the new defaults. 2. Try to upload any webp image 3. Try to crop and resize the image 4. Try to rename the image 5. Get a shareable link and make sure it works
joomla-cms-bot
added
NPM Resource Changed
|
@brianteeman on a fresh install using launch.joomla.org i did a Upload & Update using a prebuilt package. Upload of webp-image works, not crop and resize as the changes are not saved. I didn't test further cause i didn't do the test instructions "do a fresh install with the prebuilt package OR apply this pr, run npm" and i guessed thats why the changes are not saved. If my guess is wrong i can mark the test as unsuccessfully. |
Without following those test instructions it wont work |
…3091) * [J4] btn-group-yesno: success color only applied to 1 value When using the `btn-group-yesno` class on radio buttons in XML forms, the green `btn-outline-success` is applied to options with a value other than `0`. This causes multiple buttons to be green. This PR fixes that. It also fixes the issue with the `disabled` attribute not being added to the options when using the `btn-group-yesno` class. * Fixes class not being overridable
* Remove unnecessary version compare
When setting the default menu item on and off you will see that the publish up and publish down fields are shown/hidden as appropriate. However because they are above the home button it creates a usability and an accessibility as you have already navigated passed those fields. This PR simply changes the order.
* remove btn-group * remove blank lines * indent
) * add required attribute to input * add invalid template name in language * display error message * revert template error message * use existing language constant for error message * Update administrator/components/com_templates/src/Controller/TemplateController.php Co-authored-by: Quy <quy@fluxbb.org> Co-authored-by: Quy <quy@fluxbb.org>
… deprecations/types/[] (joomla#33457) * add check for intl and moderise code and remove deprecated calls * php modernisation * HArd code the names of PHP Extensions to avoid them being translated
* add fieldset and legend in com_messages * remove unused language constant Ran a global search using IDE and couldn't find this being used anywhere in the entire repository * add new constant for configuration form * update legend text * arrange imports in lexicographic order * rename constant * rename constant in legend text Co-authored-by: Richard Fath <richard67@users.noreply.github.com> Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
Cleanup output of email field
Pull Request for Issue joomla#33465 Change the icon when the toggle editor button is toggled
The markup for the Unpublished, Not Published Yet and Expired badges that is displayed in various views on the front end to administrators was incorrect. ### Before ### After
This reverts commit 6d974127490183d2412db14acee1755cedd0b493.
joomla#31048 added support for webp images however it was not complete. MediaHelper::isImage was not updated to support webp. As a result while webp could be added to media manager as an allowed image format everything worked except for the display of the thumbnail. As this PR fixes that we might as well add webp to the default list of supported image formats. To test 1. either do a fresh install with the prebuilt package OR apply this pr, run npm ci and go to the media manager options. delete all the values in the Legal Extensions (File Types), Legal Image Extensions (File Types) and Legal MIME Types and then save the options. This will reset the value to the new defaults. 2. Try to upload any webp image 3. Try to crop and resize the image 4. Try to rename the image 5. Get a shareable link and make sure it works
This reverts commit 6d974127490183d2412db14acee1755cedd0b493.
brianteeman
requested review from
bembelimen,
HLeithner,
wilsonge and
zero-24
as code owners
joomla-cms-bot
removed
the
NPM Resource Changed
|
closed - will make new pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#31048 added support for webp images however it was not complete. MediaHelper::isImage was not updated to support webp. As a result while webp could be added to media manager as an allowed image format everything worked except for the display of the thumbnail.
As this PR fixes that we might as well add webp to the default list of supported image formats.
To test
Before
After