Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Remove padding between module positions #33310

Merged
merged 1 commit into from
Apr 25, 2021

Conversation

drmenzelit
Copy link
Contributor

Pull Request for Issue #32165 .

Summary of Changes

Removed padding for containers.

Testing Instructions

See issue

Actual result BEFORE applying this Pull Request

Big padding between containers.

Expected result AFTER applying this Pull Request

No big space between container.

Documentation Changes Required

@drmenzelit drmenzelit added this to the Joomla 4.0 milestone Apr 25, 2021
@joomla-cms-bot joomla-cms-bot added the NPM Resource Changed This Pull Request can't be tested by Patchtester label Apr 25, 2021
@ChristineWk
Copy link

I have tested this item ✅ successfully on a6bb9ad


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33310.

@ChristineWk
Copy link

Before:

screen shot 2021-04-25 at 17 01 30

With Prebuild Package:

screen shot 2021-04-25 at 17 01 53


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33310.

@richard67
Copy link
Member

I have tested this item ✅ successfully on a6bb9ad


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33310.

@joomla-cms-bot joomla-cms-bot removed this from the Joomla 4.0 milestone Apr 25, 2021
@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33310.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 25, 2021
@richard67 richard67 added this to the Joomla 4.0 milestone Apr 25, 2021
@drmenzelit drmenzelit changed the title Remove padding between module positions [4.0] Remove padding between module positions Apr 25, 2021
@Quy Quy merged commit 69e62ae into joomla:4.0-dev Apr 25, 2021
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 25, 2021
@Quy
Copy link
Contributor

Quy commented Apr 25, 2021

Thanks

@drmenzelit drmenzelit deleted the 4.0-dev-gap branch May 7, 2021 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants