Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3] Routing: Fix notice in NoMenuRule #34049

Merged
merged 2 commits into from
Jun 10, 2021
Merged

[3] Routing: Fix notice in NoMenuRule #34049

merged 2 commits into from
Jun 10, 2021

Conversation

Hackwar
Copy link
Member

@Hackwar Hackwar commented May 20, 2021

Pull Request for Issue #25837.

Summary of Changes

This is an attempt of fixing the issue described in #25837. Unfortunately I can't replicate the issue and this fix is purely by codereview. Maybe @EricdeWaal can help with this? Does this solve your issue?

Testing Instructions

Due to the circumstances, I don't have test instructions.

@Hackwar
Copy link
Member Author

Hackwar commented May 20, 2021

#34050 would fix this in J4.

Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
@joomdonation
Copy link
Contributor

I have tested this item ✅ successfully on a413c30


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34049.

@richard67
Copy link
Member

I have tested this item ✅ successfully on a413c30

Code review.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34049.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34049.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 31, 2021
@chmst chmst merged commit 95d8d44 into joomla:staging Jun 10, 2021
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 10, 2021
@chmst
Copy link
Contributor

chmst commented Jun 10, 2021

Thanks!

@chmst chmst added this to the Joomla! 3.9.28 milestone Jun 10, 2021
@Hackwar Hackwar deleted the patch-5 branch January 19, 2022 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants