Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Fix short array syntax #34802

Merged
merged 1 commit into from
Jul 18, 2021
Merged

Conversation

zero-24
Copy link
Contributor

@zero-24 zero-24 commented Jul 16, 2021

Summary of Changes

Make sure we dont use the short array syntax within Joomla 3.x

Testing Instructions

Make sure you can install extensions from URL in php 5.3

Actual result BEFORE applying this Pull Request

Parse error: syntax error, unexpected '[' in administrator\components\com_installer\models\install.php on line 391

Expected result AFTER applying this Pull Request

Works

Documentation Changes Required

none

@zero-24 zero-24 added this to the Joomla! 3.9.29 milestone Jul 16, 2021
@alikon
Copy link
Contributor

alikon commented Jul 16, 2021

I have tested this item ✅ successfully on c3390b9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34802.

@richard67
Copy link
Member

I have tested this item ✅ successfully on c3390b9

Code review.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34802.

@joomla-cms-bot joomla-cms-bot removed this from the Joomla! 3.9.29 milestone Jul 16, 2021
@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34802.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 16, 2021
@zero-24 zero-24 added this to the Joomla! 3.9.29 milestone Jul 18, 2021
@zero-24
Copy link
Contributor Author

zero-24 commented Jul 18, 2021

Merging for now thanks!

@zero-24 zero-24 merged commit db24fef into joomla:staging Jul 18, 2021
@zero-24 zero-24 deleted the zero-24-patch-1 branch July 18, 2021 06:38
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 18, 2021
@sakiss
Copy link
Contributor

sakiss commented Jul 19, 2021

Btw. Is this some type of code style requirement?

@alikon
Copy link
Contributor

alikon commented Jul 19, 2021

no j3 minimum requirement for php is 5.3 where short array syntax is illegal

@zero-24 zero-24 modified the milestones: Joomla! 3.9.29, Joomla 3.10.0 Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants