[4.x] Fix error from last upmerge from 3.10-dev causing issue 36730

[richard67]

Pull Request for Issue #36730 .

Summary of Changes

Fix the error not using the injected database object but an undefined $db variable coming from the upmerge of PR #34640 from 3.10-dev into 4.0-dev 10 days ago.

Thanks to @SniperSister for the hint.

Testing Instructions

Either just code review, or have a site updated from 4.0.5 to 4.0.6 where you can reproduce issue #36730 and check if this fix solves it.

Actual result BEFORE applying this Pull Request

Unhandled PHP error in file "plugins/system/redirect/redirect.php", line 243 causes a server error when having redirects.

Expected result AFTER applying this Pull Request

No unhandled PHP error in file "plugins/system/redirect/redirect.php", line 243 causes a server error when having redirects.

Documentation Changes Required

None.

[brianteeman]

guess that @wilsonge might have one more release to do after all. ;)

[richard67]

guess that @wilsonge might have one more release to do after all. ;)

Yes, it looks like something we should fix quickly, either with a quick release or with a known issue in documentation for 4.0.6.

[richard67]

In fact it is a tricky error. When doing the upmerge and checking the differences, you don't really see that. You really have to know the complete file to see that there is no local $db variable anymore in that routine but an injected class variable to be used.

[SniperSister]

Tested the patch, works fine!

[richard67]

Tested the patch, works fine!

@SniperSister Could you mark that in the issue tracker?

[ipresencesa]

Version 4.0.7-dev #36733 is working like a charm.

Thank you

[richard67]

Version 4.0.7-dev #36733 is working like a charm.

Thank you

@ipresencesa Please go to the issue tracker here https://issues.joomla.org/tracker/joomla-cms/36733 and use the "Test this" button to mark your test result. Thanks in advance.

[mahbr]

I have tested this item ✅ successfully on c01655e

Thanks very much for the rapid and working solution :-)

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36733.}

[richard67]

Credits should go to @SniperSister because he pointed me to that thing I've missed when checking the call stack posted in the issue.