-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrong update SQL file names #37382
Fix wrong update SQL file names #37382
Conversation
it has bever been released right? |
Setting the release blocker label because we should not ship with wrong file names. Even if that will not cause problems at the update, it will later require to delete both the files with the wrong and with the right name when updating to 4.1 or 4.2, and that would simply be silly. |
@zero-24 It has been release only as release candidate. Does this justify to keep the deletion of the files with the wrong names in script.php on 4.1-dev and 4.2-dev? I think we should keep it to be safe. Otherwise in case if someone updates from 3.10.7 RC 1 to 4.1 or 4.2, there might be a problem. |
@zero-24 If we want to be safe also for an update from 3.10.7 RC1 to 3.10.7 RC 2, I would have to add deletion of the file with the wrong name even to script.php here in the 3.10-dev branch. Shall I do that? |
…thub.com/richard67/joomla-cms into 3.10-dev-fix-wrong-update-sql-file-names
PR for 4.1-dev is #37383 . |
merged thanks |
Pull Request for Issue # .
Summary of Changes
Fix wrong update SQL file names caused by commit a73ee45 .
Testing Instructions
Code review.
Actual result BEFORE applying this Pull Request
Wrong file name "3.10.7-2022-02-20.sql.sql" for the postgresql and the sqlazure files.
Expected result AFTER applying this Pull Request
Right file name "3.10.7-2022-02-20.sql" for the postgresql and the sqlazure files like it is already for the mysql file.
Documentation Changes Required
None.