Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong update SQL file names #37382

Merged

Conversation

richard67
Copy link
Member

@richard67 richard67 commented Mar 26, 2022

Pull Request for Issue # .

Summary of Changes

Fix wrong update SQL file names caused by commit a73ee45 .

Testing Instructions

Code review.

Actual result BEFORE applying this Pull Request

Wrong file name "3.10.7-2022-02-20.sql.sql" for the postgresql and the sqlazure files.

Expected result AFTER applying this Pull Request

Right file name "3.10.7-2022-02-20.sql" for the postgresql and the sqlazure files like it is already for the mysql file.

Documentation Changes Required

None.

@zero-24
Copy link
Contributor

zero-24 commented Mar 26, 2022

I will make a PR in a few minutes for the 4.1-dev branch which also should go up into 4.2-dev to fix the wrong file name also in the list of files to be deleted on update in script.php.

it has bever been released right?

@richard67
Copy link
Member Author

Setting the release blocker label because we should not ship with wrong file names. Even if that will not cause problems at the update, it will later require to delete both the files with the wrong and with the right name when updating to 4.1 or 4.2, and that would simply be silly.

@zero-24 zero-24 added this to the Joomla 3.10.7 milestone Mar 26, 2022
@richard67
Copy link
Member Author

@zero-24 It has been release only as release candidate. Does this justify to keep the deletion of the files with the wrong names in script.php on 4.1-dev and 4.2-dev? I think we should keep it to be safe. Otherwise in case if someone updates from 3.10.7 RC 1 to 4.1 or 4.2, there might be a problem.

@richard67
Copy link
Member Author

@zero-24 If we want to be safe also for an update from 3.10.7 RC1 to 3.10.7 RC 2, I would have to add deletion of the file with the wrong name even to script.php here in the 3.10-dev branch. Shall I do that?

@richard67
Copy link
Member Author

PR for 4.1-dev is #37383 .

@zero-24 zero-24 merged commit a637d32 into joomla:3.10-dev Mar 26, 2022
@zero-24
Copy link
Contributor

zero-24 commented Mar 26, 2022

merged thanks

@richard67 richard67 deleted the 3.10-dev-fix-wrong-update-sql-file-names branch March 26, 2022 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants