Template Override Actions #38447
Merged
Template Override Actions #38447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a button to remove a record but not to mark it as checked or unchecked. You had to do each one individually by clicking on the icon. This PR lets you select as many records as you want and then use the button to change all the selected records. This is based on user feedback who complained that there was no way to bulk mark records.
|
I have tested this item ✅ successfully on 0af4b65
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38447. |
|
If someone could help with the drone error I would aappreciate it as I dont understand it. |
@brianteeman The file contains a class definition and also execute code outside the class here: . Could you move that code to somewhere inside the class? |
|
I have tested this item ✅ successfully on 2b6b9f0 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38447. |
|
I have tested this item ✅ successfully on 2b6b9f0 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38447. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38447. |
heelc29
suggested changes
Aug 18, 2022
administrator/components/com_templates/src/View/Template/HtmlView.php
Outdated
Show resolved
Hide resolved
roland-d
reviewed
Aug 31, 2022
…iew.php Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
|
Thank you |
|
thanks |
Kostelano
added a commit
to JPathRu/localisation
that referenced
this pull request
Sep 2, 2022
joomla/joomla-cms#38638 + joomla/joomla-cms#38622 + joomla/joomla-cms#38619 + joomla/joomla-cms#38592 + joomla/joomla-cms#38541 - (только для en-GB) joomla/joomla-cms#38537 - (только для en-GB) joomla/joomla-cms#38570 + joomla/joomla-cms#38459 + joomla/joomla-cms#38451 + joomla/joomla-cms#38449 + joomla/joomla-cms#38313 + joomla/joomla-cms#38447 +
brianteeman
added a commit
to brianteeman/joomla-cms
that referenced
this pull request
Dec 1, 2022
This fixes a bug exposed in my own pr joomla#38447 That PR added an action dropdown button When you have overrides. See the original PR for details However it also added the dropdown when the file was open for editing but at that point it can be selected because it is never active. This PR removes the button when the file is open for editing. A better PR would be to make it (or a similar button) work in the edit mode but I don't have the time (and probably the skill) to do that. So at this time I consider this PR a bug fix and the functionality can be added at a later date in another pr Testing requires overrides that need checking. You can simulate this by 1. Create template overrides for com_content/article and com_newsfeed/feed 2. Run this sql query replacing #_ with your db prefix INSERT INTO `#__template_overrides` (`id`, `template`, `hash_id`, `extension_id`, `state`, `action`, `client_id`, `created_date`, `modified_date`) VALUES (1, 'cassiopeia', 'L2h0bWwvY29tX25ld3NmZWVkcy9uZXdzZmVlZC9kZWZhdWx0LnBocA==', 223, 0, 'Joomla Update', 0, '2022-09-01 13:51:54', '2022-09-01 13:51:54'), (2, 'cassiopeia', 'L2h0bWwvY29tX2NvbnRlbnQvYXJ0aWNsZS9kZWZhdWx0X2xpbmtzLnBocA==', 223, 0, 'Joomla Update', 0, '2022-09-01 13:51:54', '2022-09-01 13:51:54'); You will now have two override files to update and can test this PR
roland-d
pushed a commit
that referenced
this pull request
Dec 18, 2022
This fixes a bug exposed in my own pr #38447 That PR added an action dropdown button When you have overrides. See the original PR for details However it also added the dropdown when the file was open for editing but at that point it can be selected because it is never active. This PR removes the button when the file is open for editing. A better PR would be to make it (or a similar button) work in the edit mode but I don't have the time (and probably the skill) to do that. So at this time I consider this PR a bug fix and the functionality can be added at a later date in another pr Testing requires overrides that need checking. You can simulate this by 1. Create template overrides for com_content/article and com_newsfeed/feed 2. Run this sql query replacing #_ with your db prefix INSERT INTO `#__template_overrides` (`id`, `template`, `hash_id`, `extension_id`, `state`, `action`, `client_id`, `created_date`, `modified_date`) VALUES (1, 'cassiopeia', 'L2h0bWwvY29tX25ld3NmZWVkcy9uZXdzZmVlZC9kZWZhdWx0LnBocA==', 223, 0, 'Joomla Update', 0, '2022-09-01 13:51:54', '2022-09-01 13:51:54'), (2, 'cassiopeia', 'L2h0bWwvY29tX2NvbnRlbnQvYXJ0aWNsZS9kZWZhdWx0X2xpbmtzLnBocA==', 223, 0, 'Joomla Update', 0, '2022-09-01 13:51:54', '2022-09-01 13:51:54'); You will now have two override files to update and can test this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a button to remove a record but not to mark it as checked or unchecked. You had to do each one individually by clicking on the icon.
This PR lets you select as many records as you want and then use the button to change all the selected records. This is based on user feedback who complained that there was no way to bulk mark records.
Before
chrome_cPbU2OavOI.mp4
After
chrome_MlHkWUo6dg.mp4