[4.3] Deprecation reviews #38657
Merged
[4.3] Deprecation reviews #38657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
wilsonge
reviewed
Aug 31, 2022
wilsonge
reviewed
Aug 31, 2022
wilsonge
reviewed
Aug 31, 2022
|
Is this hashtag deprecated format actually recognised by PHP Documentor? I'm only seeing this as a reference? https://docs.phpdoc.org/latest/guide/references/phpdoc/tags/deprecated.html I mean I'm down for the concept. But I don't understand most the implementation |
Continue with deprecations
No it isn't, that's my marker for the deprecations I already handled. Will then be converted at the end back to @ |
|
I wouldnt bother using the word "instead" its a superfluous word
==>
|
Added new line
Added new line
|
Thank you Benjamin @bembelimen for this thorough PR. It will be a great help. |
brianteeman
added a commit
to brianteeman/joomla-cms
that referenced
this pull request
Jul 23, 2023
wilsonge
pushed a commit
that referenced
this pull request
Aug 4, 2023
GeraintEdwards
pushed a commit
to GeraintEdwards/joomla-cms
that referenced
this pull request
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to add a code example to each @Deprecation in the Joomla core and also add clear versions when somehing was deprecated and the earliest version when it can be removed.
This PR is still a draft, as there is a lot of chaos and it takes some time to clean up (some versions will also change).