Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.2] Fix move user to group #39483

Merged
merged 1 commit into from
Dec 28, 2022
Merged

Conversation

heelc29
Copy link
Contributor

@heelc29 heelc29 commented Dec 23, 2022

Summary of Changes

The feature to move an user to a group is broken after #38596.

Variable $users is not assigned in this if-case. Use the correct variable $userIds like it was before #38596

// Remove users from the group
$query->delete($db->quoteName('#__user_usergroup_map'))
->whereIn($db->quoteName('user_id'), $userIds);

Testing Instructions

Try moving a user to a group using the batch command.
image

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

The user is moved to the new group.
image

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed

@alikon
Copy link
Contributor

alikon commented Dec 24, 2022

I have tested this item ✅ successfully on e3326d8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39483.

1 similar comment
@ceciogit
Copy link

I have tested this item ✅ successfully on e3326d8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39483.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39483.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 24, 2022
@wilsonge wilsonge merged commit d9e2152 into joomla:4.2-dev Dec 28, 2022
@wilsonge
Copy link
Contributor

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Dec 28, 2022
@wilsonge wilsonge added this to the Joomla! 4.2.7 milestone Dec 28, 2022
@heelc29 heelc29 deleted the 4.2/users-batch-group branch December 29, 2022 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants