-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Batch process on users #38596
Batch process on users #38596
Conversation
The batch process on users lets you remove a user from a group. But it doesn't check to make sure that the user is still in at least one group. ## To test ### Test 1 1. Create a new user and put them in the registered usergroup 2. Using the batch process try to remove them from the registered usergroup #### Before Success message and user now not in any group #### After Batch process failed with following error: A user must belong to at least one group. ### Test 2 1. Create a new user and put them in the registered AND author usergroup 2. Using the batch process try to remove them from the editor usergroup #### Before Success message and user still in the registered and author usergroups #### After Batch process failed with following error: The selected user(s) are not in the selected group. ### Test 3 1. Create a new user and put them in the registered AND author usergroup 2. Using the batch process try to remove them from the registered usergroup #### Before Success message and user only in the author usergroup #### After Success message and user only in the author usergroup #### Comments This type of code is really not my strong point - it may need optimizing etc
I have tested this item ✅ successfully on 2081df5 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38596. |
1 similar comment
I have tested this item ✅ successfully on 2081df5 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38596. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38596. |
I remember a rule that comments have to start with a capital lettter? |
@chmst yes you're right my bad. also the multiline comment should not use // suprised the code style check didnt pick this up. I will update shortly |
Thank you! Great branch name :D |
Wow this gets merged but removing unused CSS doesn't. Makes no sense |
joomla/joomla-cms#38670 - (только для en-GB) joomla/joomla-cms#38463 + joomla/joomla-cms#38703 - (только для en-GB) joomla/joomla-cms#38208 + joomla/joomla-cms#38704 - (только для en-GB) joomla/joomla-cms#38732 - (только для en-GB) joomla/joomla-cms#38772 - (только для en-GB) joomla/joomla-cms#38596 +
Pull request for #32732
The batch process on users lets you remove a user from a group. But it doesn't check to make sure that the user is still in at least one group.
To test
Test 1
Before
Success message and user not in any group
After
Batch process failed with following error: A user must belong to at least one group.
Test 2
Before
Success message and user still in the registered and author usergroups
After
Batch process failed with following error: The selected user(s) are not in the selected group.
Test 3
Before
Success message and user only in the author usergroup
After
Success message and user only in the author usergroup
Comments
This type of code is really not my strong point - it may need optimizing etc