Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.4] remove deprecation from used string #40533

Merged
merged 1 commit into from
May 8, 2023
Merged

[4.4] remove deprecation from used string #40533

merged 1 commit into from
May 8, 2023

Conversation

heelc29
Copy link
Contributor

@heelc29 heelc29 commented May 3, 2023

Summary of Changes

remove deprecation from used string (added with #40493)

Testing Instructions

save a news feed

Actual result BEFORE applying this Pull Request

if COM_NEWSFEEDS_SAVE_SUCCESS is removed
image

Expected result AFTER applying this Pull Request

if COM_NEWSFEEDS_SAVE_SUCCESS still present
image

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.4-dev labels May 3, 2023
This was referenced May 3, 2023
Closed
Open
@chmst chmst added the Small A PR which only has a small change label May 4, 2023
@laoneo
Copy link
Member

laoneo commented May 5, 2023

@brianteeman was there any intention we miss with the removal of COM_NEWSFEEDS_SAVE_SUCCESS?

@laoneo laoneo self-assigned this May 5, 2023
@laoneo laoneo merged commit bfa352e into joomla:4.4-dev May 8, 2023
@laoneo
Copy link
Member

laoneo commented May 8, 2023

Thanks!

@laoneo laoneo added this to the Joomla! 4.4.0 milestone May 8, 2023
@heelc29 heelc29 deleted the 4.4/patch-40493 branch May 8, 2023 15:58
@jgerman-bot jgerman-bot mentioned this pull request May 9, 2023
Closed
@joomlapl-bot joomlapl-bot mentioned this pull request May 9, 2023
Closed
Kostelano added a commit to JPathRu/localisation that referenced this pull request Sep 4, 2023
@Kostelano
Новое в Joomla 4.4.0 Alpha 4
1de0bdb 
* Новое в Joomla 4.4.0 Alpha 4
joomla/joomla-cms#40071 +
joomla/joomla-cms#40259 - (вероятно, ошибка при обновлении ветки автора)
joomla/joomla-cms#40466 +
joomla/joomla-cms#40469 +
joomla/joomla-cms#40493 +
joomla/joomla-cms#40510 +
joomla/joomla-cms#40534 +
joomla/joomla-cms#40533 +
joomla/joomla-cms#40565 +
joomla/joomla-cms#41024 +
joomla/joomla-cms#40774 +
joomla/joomla-cms#41099 +
joomla/joomla-cms#41379 +
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@laoneo laoneo

Labels
Language Change This is for Translators PR-4.4-dev Small A PR which only has a small change
Projects
None yet
Milestone
Joomla! 4.4.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@heelc29 @laoneo @chmst @joomla-cms-bot