Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.4] Deprecate unused language strings #40466

Merged
merged 2 commits into from
May 2, 2023

Conversation

brianteeman
Copy link
Contributor

These language strings are not used in Joomla 4. They were added to address an issue with #31884 but then the entire view was removed with #32933

Test either by code review or simply edit one of the strings and see if the edited string is rendered either when you go to com_users and edit a user profile or when you click on your own username from the edit account link in the dropdown in the top right

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

These language strings are not used in Joomla 4. They were added to address an issue with joomla#31884 but then the entire view was removed with joomla#32933

Test either by code review or simply edit one of the strings and see if the edited string is rendered either when you go to com_users and edit a user profile or when you click on your own username from the edit account link in the dropdown in the top right
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.3-dev labels Apr 24, 2023
@brianteeman brianteeman changed the base branch from 4.3-dev to 4.4-dev April 24, 2023 16:00
@brianteeman brianteeman changed the title [4.3] Deprecate unused language strings [4.4] Deprecate unused language strings Apr 24, 2023
@Quy Quy removed the PR-4.3-dev label Apr 25, 2023
@laoneo laoneo merged commit 977f515 into joomla:4.4-dev May 2, 2023
@laoneo
Copy link
Member

laoneo commented May 2, 2023

Thanks!

@laoneo laoneo added this to the Joomla! 4.4.0 milestone May 2, 2023
@brianteeman
Copy link
Contributor Author

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators PR-4.4-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants