Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Convert mod_banners to service provider #42214

Merged
merged 4 commits into from Jan 24, 2024

Conversation

heelc29
Copy link
Contributor

@heelc29 heelc29 commented Oct 24, 2023

Summary of Changes

Converts the banners site module to service provider

Testing Instructions

  • create site module Banners
  • check site output

Note: system test exists
https://github.com/joomla/joomla-cms/blob/5.1-dev/tests/System/integration/site/modules/mod_banners/Default.cy.js

Actual result BEFORE applying this Pull Request

module works
image

Expected result AFTER applying this Pull Request

module works
image

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed

@laoneo laoneo self-assigned this Oct 25, 2023
@ceford
Copy link
Contributor

ceford commented Oct 27, 2023

I have tested this item ✅ successfully on 57e0557


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42214.

@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 0c3ff13


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42214.

@LadySolveig LadySolveig merged commit c03bab7 into joomla:5.1-dev Jan 24, 2024
3 checks passed
@LadySolveig
Copy link
Contributor

Thank you @heelc29 and for testing and review @ceford @viocassel @sandewt

@Quy Quy added this to the Joomla! 5.1.0 milestone Jan 24, 2024
@heelc29 heelc29 deleted the 5.1/modules/site/banners branch January 27, 2024 10:28
richard67 added a commit to richard67/joomla-cms that referenced this pull request Feb 10, 2024
richard67 added a commit to richard67/joomla-cms that referenced this pull request Feb 10, 2024
LadySolveig pushed a commit that referenced this pull request Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants