[5.1] Convert mod_banners to service provider#42214
Merged
LadySolveig merged 4 commits intojoomla:5.1-devfrom Jan 24, 2024
Merged
[5.1] Convert mod_banners to service provider#42214LadySolveig merged 4 commits intojoomla:5.1-devfrom
LadySolveig merged 4 commits intojoomla:5.1-devfrom
Conversation
sandewt
reviewed
Oct 26, 2023
Contributor
|
I have tested this item ✅ successfully on 57e0557 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42214. |
Contributor
|
I have tested this item ✅ successfully on 0c3ff13 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42214. |
Contributor
|
Thank you @heelc29 and for testing and review @ceford @viocassel @sandewt |
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Feb 10, 2024
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Feb 10, 2024
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Converts the banners site module to service provider
Testing Instructions
BannersNote: system test exists
https://github.com/joomla/joomla-cms/blob/5.1-dev/tests/System/integration/site/modules/mod_banners/Default.cy.js
Actual result BEFORE applying this Pull Request
module works
Expected result AFTER applying this Pull Request
module works
Link to documentations
Please select: