Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Article Schemaorg plugin #42402

Merged
merged 14 commits into from Jan 10, 2024
Merged

Conversation

brianteeman
Copy link
Contributor

Summary of Changes

Simple PR to add the most basic type of schema - Article

Testing Instructions

Install prebuilt package or discover->install and publish plugin

Check that article is in the list of available schema in a content item
Add some values, save the article and then test the generated json-ld markup on the page at https://search.google.com/test/rich-results

Link to documentations

Can't find any documentation for the schemaorg plugins. If you can point me at it then I can add this new schema

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Simple PR to add the most basic type of schema - Article
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-5.1-dev labels Nov 27, 2023
@sandewt
Copy link
Contributor

sandewt commented Nov 27, 2023

Possibly a useful link to support testing: https://magazine.joomla.org/all-issues/september/rich-snippets-in-joomla-5

@fgsw
Copy link

fgsw commented Dec 13, 2023

I have tested this item ✅ successfully on 2f5f1c5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42402.

@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 1d4e1b4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42402.

@richard67
Copy link
Member

I've restored the results from previous human tests as the commits after that were just version number changes, which I've all reviewed right now.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42402.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 5, 2024
@LadySolveig LadySolveig added this to the Joomla! 5.1.0 milestone Jan 10, 2024
@LadySolveig LadySolveig merged commit 53259aa into joomla:5.1-dev Jan 10, 2024
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 10, 2024
@LadySolveig
Copy link
Contributor

Thank you @brianteeman
And also many thanks to all who have participated here with tests and informations @sandewt @fgsw @viocassel @richard67

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants