Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Uninstall child of package #42607

Merged
merged 5 commits into from Jan 7, 2024
Merged

Conversation

brianteeman
Copy link
Contributor

Pull Request for Issue #42596 .

Summary of Changes

If you try to uninstall an extension that is a package you can't and get a message doesnt indicate what package.

This pr adds a new variable to the string so that there is now a direct link to the package

Because of our semver rules on language strings this is made against j5.1

Testing Instructions

Install any package extension eg a language
Go to System => Manage => Extensions
Filter for languages and then try to uninstall one

Actual result BEFORE applying this Pull Request

The < named > extension is part of a [ package ] which does not allow individual extensions to be uninstalled.

Expected result AFTER applying this Pull Request

The < named > extension is part of a [ package ]( index.php?option=com_installer&view=manage&filter[search]=id:XX) which does not allow individual extensions to be uninstalled.

The link will directly open the package so it can be selected and uninstalled.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@fgsw
Copy link

fgsw commented Jan 4, 2024

After click on direct link in the message:

Untitled

After click on search-button the package is shown and can be uninstalled.

@brianteeman
Copy link
Contributor Author

@fgsw Thanks for testing. I have updated the pr to resolve your issue

@Kostelano
Copy link
Contributor

I have tested this item ✅ successfully on b0a0162


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42607.

@fgsw
Copy link

fgsw commented Jan 5, 2024

I have tested this item ✅ successfully on b0a0162

Thanks @brianteeman


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42607.

@alikon
Copy link
Contributor

alikon commented Jan 5, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42607.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 5, 2024
@Razzo1987 Razzo1987 added this to the Joomla! 5.1.0 milestone Jan 6, 2024
@Razzo1987 Razzo1987 merged commit dcade15 into joomla:5.1-dev Jan 7, 2024
3 checks passed
@Razzo1987
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators PR-5.1-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants